From owner-svn-ports-head@freebsd.org  Mon Aug 13 02:20:32 2018
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 412541062304;
 Mon, 13 Aug 2018 02:20:32 +0000 (UTC) (envelope-from zi@freebsd.org)
Received: from exodus.zi0r.com (exodus.zi0r.com [71.179.14.195])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "exodus.zi0r.com", Issuer "Gandi Standard SSL CA 2" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id EB19484BA9;
 Mon, 13 Aug 2018 02:20:31 +0000 (UTC) (envelope-from zi@freebsd.org)
Received: from exodus.zi0r.com (syn.zi0r.com [71.179.14.194])
 (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by exodus.zi0r.com (Postfix) with ESMTPSA id E7AC76A8A81;
 Sun, 12 Aug 2018 22:20:29 -0400 (EDT)
Date: Sun, 12 Aug 2018 22:20:28 -0400
From: Ryan Steinmetz <zi@freebsd.org>
To: Adam Weinberger <adamw@adamw.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r477046 - in head/net: avahi avahi-app
 avahi-app/files avahi-gtk avahi-gtk3 avahi-header avahi-libdns avahi-qt4
 avahi-sharp py-avahi
Message-ID: <20180813022028.GA24286@exodus.zi0r.com>
References: <201808130149.w7D1nxiv054335@repo.freebsd.org>
 <CAP7rwch89xzNmtFDNwof0os3K4hg23nJmBZcxNm7eb9zsn=MBw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <CAP7rwch89xzNmtFDNwof0os3K4hg23nJmBZcxNm7eb9zsn=MBw@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Aug 2018 02:20:32 -0000


On (08/12/18 19:55), Adam Weinberger wrote:
>Ryan,
>
>Are you sure this is what you want? It discards MAKE_ENV and
>MAKE_ARGS. Consider using DO_MAKE_BUILD instead, which preserves them:
>
>    ${DO_MAKE_BUILD} -C ${WRKSRC}/avahi-common
>    ${DO_MAKE_BUILD} -C ${WRKSRC}/avahi-client
>etc.
>

Build succeeds with your proposal, so I've amended the commit.  
Originally, I had followed the existing build process from net/avahi-gtk3's 
Makefile:

https://svnweb.freebsd.org/ports/head/net/avahi-gtk3/Makefile?r1=359184&r2=359185&

-r

># Adam
>
>
>-- 
>Adam Weinberger
>adamw@adamw.org
>https://www.adamw.org

-- 
Ryan Steinmetz
PGP: 9079 51A3 34EF 0CD4 F228  EDC6 1EF8 BA6B D028 46D7