From owner-dev-commits-src-all@freebsd.org Tue Apr 20 16:24:39 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DD6825DE3D5; Tue, 20 Apr 2021 16:24:39 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FPptH5x9wz3CYK; Tue, 20 Apr 2021 16:24:39 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: from freefall.freebsd.org (pool-100-8-53-238.nwrknj.fios.verizon.net [100.8.53.238]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jkim/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id A8D12DAED; Tue, 20 Apr 2021 16:24:39 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Subject: Re: git: 686cf5468c4a - main - flex: Regen bootstrap files To: rgrimes@freebsd.org Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202104201609.13KG9w0e071568@gndrsh.dnsmgr.net> From: Jung-uk Kim Organization: FreeBSD.org Message-ID: <782d3c7b-fb30-d013-0426-692cc1ead645@FreeBSD.org> Date: Tue, 20 Apr 2021 12:24:35 -0400 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <202104201609.13KG9w0e071568@gndrsh.dnsmgr.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Apr 2021 16:24:39 -0000 On 21. 4. 20., Rodney W. Grimes wrote: >> On 21. 4. 20., Rodney W. Grimes wrote: >>>> The branch main has been updated by jkim: >>>> >>>> URL: https://cgit.FreeBSD.org/src/commit/?id=686cf5468c4a85c2a6385cdbab2383900876a41d >>>> >>>> commit 686cf5468c4a85c2a6385cdbab2383900876a41d >>>> Author: Jung-uk Kim >>>> AuthorDate: 2021-04-19 18:20:51 +0000 >>>> Commit: Jung-uk Kim >>>> CommitDate: 2021-04-19 18:20:51 +0000 >>>> >>>> flex: Regen bootstrap files >>>> >>>> This also partially reverts r326025 (8a16b7a18f5d). I do not see any >>>> point of adding SPDX tag in generated file. >>> >>> The SPDX identifies the copyright that follows it, so please put this back. >> >> It is a generated file. If you really think it is necessary, you need >> to patch its source, i.e., contrib/flex/src/parse.y, and regen the file. > > Just because it is a generated file does not change the fact that > its contents are copyrighted. Leaving the copyright out at best > defaults to Bern convention, so the fact of the mater is the contents > is copyrighted, and it is best to explicitly state that it is. Of course, it is copyrighted. My point was parse.y should have been patched, not the generated file, if necessary. >> However, I don't see much sense in automatically adding BSD license in >> every generated file in the first place. In fact, I think it should not >> appear on generated file at all. It may say something along the line of >> "generated by flex" instead but IANAL. > > Well, someone before you did see since in it, and hence put that SPDX in it. Let me put it in another way. Do we really want to tag contrib code? Jung-uk Kim