From owner-freebsd-arch@FreeBSD.ORG Thu Apr 1 21:22:45 2010 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C7DB6106567B; Thu, 1 Apr 2010 21:22:45 +0000 (UTC) (envelope-from des@des.no) Received: from smtp.des.no (smtp.des.no [194.63.250.102]) by mx1.freebsd.org (Postfix) with ESMTP id 7EE9F8FC15; Thu, 1 Apr 2010 21:22:45 +0000 (UTC) Received: from ds4.des.no (des.no [84.49.246.2]) by smtp.des.no (Postfix) with ESMTP id 447971FFC76; Thu, 1 Apr 2010 21:22:43 +0000 (UTC) Received: by ds4.des.no (Postfix, from userid 1001) id C96BD84567; Wed, 31 Mar 2010 13:24:28 +0200 (CEST) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Xin LI References: <4BACFE18.7010309@delphij.net> <86wrwylji0.fsf@ds4.des.no> <4BAD509B.3080805@delphij.net> <86ljdelhgd.fsf@ds4.des.no> <4BAD62CF.6090901@delphij.net> <868w9elego.fsf@ds4.des.no> <20100331102509.GI34892@gahrfit.gahr.ch> Date: Wed, 31 Mar 2010 13:24:28 +0200 In-Reply-To: (Xin LI's message of "Wed, 31 Mar 2010 03:41:13 -0700") Message-ID: <86pr2ksphv.fsf@ds4.des.no> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.95 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: d@delphij.net, gahr@freebsd.org, the_paya@gentoo.org, ports@freebsd.org, freebsd-arch@freebsd.org, Alexander Logvinov Subject: Re: [RFC] Reduce namespace pollution on zlib.h X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Apr 2010 21:22:46 -0000 Xin LI writes: > I will merge an upstream change from zlib, which basically unexpose > LFS stuff on FreeBSD, and I plan to keep the off_t bits =3D=3D 64. > However, I would highly recommend ports maintainers to push upstream > fix for LFS64 definition removal since they are wrong on FreeBSD LFS64 is not correct on Linux either; just #define _FILE_OFFSET_BITS 64 before #include and use struct stat / stat() as usual. The AC_SYS_LARGEFILE autoconf macro takes care of that for you, provided you remember to #include "config.h" in your code. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no