Date: Sun, 5 Jul 1998 13:40:05 -0700 (PDT) From: Niall Smart <rotel@indigo.ie> To: freebsd-bugs@FreeBSD.ORG Subject: Re: bin/7137 Message-ID: <199807052040.NAA00594@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/7137; it has been noted by GNATS.
From: Niall Smart <rotel@indigo.ie>
To: Poul-Henning Kamp <phk@critter.freebsd.dk>
Cc: tarush@mindspring.com, freebsd-gnats-submit@freebsd.org
Subject: Re: bin/7137
Date: Sun, 5 Jul 1998 18:15:53 +0000
On Jul 2, 9:20pm, Poul-Henning Kamp wrote:
} Subject: Re: bin/7137
>
> You yell and bicker about somebody who actually DOES something,
> rather than go home, test the patch on -stable and supply an
> independent confirmation that it is OK.
I was yelling and bickering about PR's which still apply to -stable
being closed, anyway, the patch works unmodified on -stable:
Index: ac.c
===================================================================
RCS file: /cvs/src/usr.sbin/ac/ac.c,v
retrieving revision 1.4.2.4
diff -C2 -r1.4.2.4 ac.c
*** ac.c 1998/06/04 21:44:32 1.4.2.4
--- ac.c 1998/07/05 17:15:34
***************
*** 504,513 ****
default:
/*
! * if they came in on tty[p-y]*, then it is only
* a login session if the ut_host field is non-empty
*/
if (*usr.ut_name) {
if (strncmp(usr.ut_line, "tty", 3) != 0 ||
! strchr("pqrstuvwxy", usr.ut_line[3]) == 0 ||
*usr.ut_host != '\0')
head = log_in(head, &usr);
--- 504,513 ----
default:
/*
! * if they came in on tty[p-sP-S]*, then it is only
* a login session if the ut_host field is non-empty
*/
if (*usr.ut_name) {
if (strncmp(usr.ut_line, "tty", 3) != 0 ||
! strchr("pqrsPQRS", usr.ut_line[3]) == 0 ||
*usr.ut_host != '\0')
head = log_in(head, &usr);
> I don't care what size patch it is, I don't commit to -stable without
> testing it, and since I don't have a machine nor time to do so, I don't
> commit to -stable.
Then don't close the PR's, mark them suspended and prefix the
synopsis to [MFC] or [STABLE] or something.
Niall
--
Niall Smart. PGP: finger njs3@motmot.doc.ic.ac.uk
FreeBSD: Turning PC's into Workstations: www.freebsd.org
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199807052040.NAA00594>