Date: Mon, 29 Jun 2020 09:10:36 +0200 From: Mathieu Arnold <mat@freebsd.org> To: Cy Schubert <Cy.Schubert@cschubert.com> Cc: Mathieu Arnold <mat@freebsd.org>, Alexey Dokuchaev <danfe@freebsd.org>, Fernando Apestegu??a <fernape@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r540489 - in head/devel/fhist: . files Message-ID: <20200629071036.ooyu4h2gkppl2j2j@aching.in.mat.cc> In-Reply-To: <202006261511.05QFBaAk045418@slippy.cwsent.com> References: <202006261034.05QAYaDe038059@repo.freebsd.org> <20200626124105.GA65385@FreeBSD.org> <20200626132841.kytmjwquonpwkrhr@aching.in.mat.cc> <202006261511.05QFBaAk045418@slippy.cwsent.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--5rem6uaqojdcr4v3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 26, 2020 at 08:11:36AM -0700, Cy Schubert wrote: > In message <20200626132841.kytmjwquonpwkrhr@aching.in.mat.cc>, Mathieu=20 > Arnold w > rites: > >=20 > > --fq3my2lrxbkpfplh > > Content-Type: text/plain; charset=3Dus-ascii > > Content-Disposition: inline > > Content-Transfer-Encoding: quoted-printable > > > > On Fri, Jun 26, 2020 at 12:41:05PM +0000, Alexey Dokuchaev wrote: > > > On Fri, Jun 26, 2020 at 10:34:36AM +0000, Fernando Apestegu??a wrote: > > > > New Revision: 540489 > > > > URL: https://svnweb.freebsd.org/changeset/ports/540489 > > > >=3D20 > > > > Log: > > > > devel/fhist: and fix bison issues and change maintership > > > >=3D20 > > > > Modified: > > > > head/devel/fhist/Makefile > > > > head/devel/fhist/files/patch-common_ac_time.h > > > >=3D20 > > > > Modified: head/devel/fhist/files/patch-common_ac_time.h > > > > =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D= =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D > > =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D= =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D > > =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D= =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D > > =3D3D=3D3D=3D3D=3D3D=3D3D > > > > --- head/devel/fhist/files/patch-common_ac_time.h Fri Jun 26 09:35:= 06 2=3D > > 020 (r540488) > > > > +++ head/devel/fhist/files/patch-common_ac_time.h Fri Jun 26 10:34:= 36 2=3D > > 020 (r540489) > > > > @@ -1,6 +1,6 @@ > > > > ---- common/ac/time.h.orig Wed Dec 18 02:09:57 2002 > > > > -+++ common/ac/time.h Wed Dec 18 02:10:04 2002 > > > > -@@ -29,7 +29,7 @@ > > > > +--- common/ac/time.h.orig 2012-07-13 04:47:15 UTC > > > > ++++ common/ac/time.h > > > > +@@ -26,7 +26,7 @@ > > > > * Catch-22: Dec Alpha OSF/1: need to include time.h before sys/t= ime.h > > > > * before time.h > > > > */ > > >=3D20 > > > Please, "svn revert" patches which forwent no functional changes prior > > > to making commit. It just clutters the diff and decreases SNR. :-( > > > > In that particular case, it was correct to commit the patch, it has > > functional change, the range information changed, and it is definitively > > not just noise. >=20 > I see no problem regenerating patches. I do have a problem with cosmetic= =20 > changes intermixed with functional changes like fix X and portlint, or fi= x=20 > X and regenerate patches. Keep them separate. They're easier for people= =20 > reading the logs to parse weeks or months from now. This change was absolutely not cosmetic, it updated the patch files to match with the current sources from the port. --=20 Mathieu Arnold --5rem6uaqojdcr4v3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEVhwchfRfuV0unqO5KesJApEdfgIFAl75k+hfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU2 MUMxQzg1RjQ1RkI5NUQyRTlFQTNCOTI5RUIwOTAyOTExRDdFMDIACgkQKesJApEd fgLGfA/+PcN80/ydsBngZHoX1EVVq5gy1M6t/Vz3Np0zXPz0tFAKojwvVFyn8yOI Z+sG/E6rlSjzrWG5TIeKnlWL5GryAKsuOj2iHmtLeis3XEPvcetktMjPu/6R2/Gd sexgNnHfv2Pka0avtpaz/OTcdOaN0kbAxtMo4YL7SF3UFq3QAuMxtB1w/MFUwRHc Z8jx7tQK4W4mt8IKN8lxUHzJWgAD3HotXQTGmdtZUUTZud9LxTmBD+4x3LUCI5AY YnlslsMMj9F8TiO0QAOaF0GEql/Br5qUd7JPixPdG/VRXX1vsV+ux2CVMQD4PwL1 N41UzpteyRqOyrRB06MIFlNT+YQzgB30W7i7DzNXV2TMv4N6L3nglUnDAMxm5T2V phsiiGBxDM2wdJbduP0qQw57+EDIEitdy5Hl30ACN4+ndy2cAlgTJS/fsi6rrsi0 0YBEqw/U5vMUkEBbrK1Pd549yIJorBuxLtguObTvRIedKlDXkuJ1xAvYNEemiQOn PKcmLsKI26ZIGnZxlJgwVvR485Pfh9jbE0VhEf5aK08t4EpOeMVi9DfnXCUZaPpO 44kpnneTAwNdYOvevRfoEjEji3R+9De8ueiujzSKLM8Wb/uA14wysqndDgcwJClc 7hFKuBf4r3RSNJcRUFPNXYjap1Cj0wSqkdFpRLMaANu1DBM/hdk= =788I -----END PGP SIGNATURE----- --5rem6uaqojdcr4v3--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200629071036.ooyu4h2gkppl2j2j>