Date: Thu, 22 Nov 2012 09:49:13 +0400 From: Eygene Ryabinkin <rea@freebsd.org> To: Bryan Drewery <bdrewery@freebsd.org> Cc: svn-ports-head@freebsd.org, Andrey Chernov <ache@freebsd.org>, svn-ports-all@freebsd.org, ports-committers@freebsd.org, Erwin Lansing <erwin@freebsd.org>, Chris Rees <utisoft@gmail.com> Subject: Re: svn commit: r307612 - in head/misc/astrolog: . files Message-ID: <yz7fBVF%2BpOkKvsMims5WGSzSy5g@7TEDb4Yy37iQCK/hgFqwmvLmFqM> In-Reply-To: <50ACF8E8.5080706@FreeBSD.org> References: <201211210949.qAL9nl4a018306@svn.freebsd.org> <CADLo83-Yf0vt73kynPPJPCEcLex11g=SzJshbqmyr=bmHWaKUA@mail.gmail.com> <50ACB0A7.1030108@freebsd.org> <CADLo839jgAP_V3F4x%2BwSaFk65rLdvS-pPhaM7krP9FWHn5cFfA@mail.gmail.com> <50ACBE7D.70203@freebsd.org> <20121121120128.GC4474@droso.net> <P1kYGGwXBWZ1fcuxwnoQYoZ6uu0@7TEDb4Yy37iQCK/hgFqwmvLmFqM> <50ACF8E8.5080706@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--GPJrCs/72TxItFYR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Wed, Nov 21, 2012 at 09:53:12AM -0600, Bryan Drewery wrote: > I agree. Splitting logically-grouped changes out into multiple patches > is confusing, especially to future maintainers. >=20 > IMHO this should not be a hard rule, but a suggestion if ordering is > problematic. Yes, but current porter guidelines say "Each patch you wish to apply should be saved into a file named patch-* where * indicates the pathname of the file that is patched, such as patch-Imakefile or patch-src-config.h" and "To make fixes and upgrades easier, you should avoid having more than one patch fix the same file (e.g., patch-file and patch-file2 both changing WRKSRC/foobar.c)", http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/slow-pa= tch.html so, a. if SHOULD is as per RFC 2119, then it means that the recommended way is to have per-file patches and the other ways should be used with the great care; b. "make fixes and upgrades easier" concern only the short-term easiness (if at all), in the long term it has just the opposite effect for non-trivial patches. I think I'll try to come up with the patch for the handbook and will post it to the wider list for comments. --=20 Eygene Ryabinkin ,,,^..^,,, [ Life's unfair - but root password helps! | codelabs.ru ] [ 82FE 06BC D497 C0DE 49EC 4FF0 16AF 9EAE 8152 ECFB | freebsd.org ] --GPJrCs/72TxItFYR Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iF4EABEIAAYFAlCtvNkACgkQFq+eroFS7PvzxgD+LSY9lGjJ+aI5XYH1etRPoz7x ahwZ+DKZlZfg7xImED8A/3v1bAZXyu8dH3yINPJuE2ZZoM5nCbTCcm3Edx2n4xbu =kMiK -----END PGP SIGNATURE----- --GPJrCs/72TxItFYR--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?yz7fBVF%2BpOkKvsMims5WGSzSy5g>