From owner-cvs-all Tue Nov 26 8:56:36 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F273537B401 for ; Tue, 26 Nov 2002 08:56:32 -0800 (PST) Received: from mail.speakeasy.net (mail11.speakeasy.net [216.254.0.211]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7FAB843E9C for ; Tue, 26 Nov 2002 08:56:32 -0800 (PST) (envelope-from jhb@FreeBSD.org) Received: (qmail 1757 invoked from network); 26 Nov 2002 16:56:32 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail11.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 26 Nov 2002 16:56:32 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.6/8.12.6) with ESMTP id gAQGuFuH013096; Tue, 26 Nov 2002 11:56:16 -0500 (EST) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20021126064832.GF49477@wantadilla.lemis.com> Date: Tue, 26 Nov 2002 11:56:20 -0500 (EST) From: John Baldwin To: "Greg 'groggy' Lehey" Subject: Re: cvs commit: src/sbin/fsck_ffs pass5.c Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Julian Elischer , Bruce Evans Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 26-Nov-2002 Greg 'groggy' Lehey wrote: > On Tuesday, 26 November 2002 at 17:59:16 +1100, Bruce Evans wrote: >> On Tue, 26 Nov 2002, Greg 'groggy' Lehey wrote: >> >>> On Monday, 25 November 2002 at 17:00:03 +1100, Bruce Evans wrote: >>>> On Sun, 24 Nov 2002, Julian Elischer wrote: >>>> >>>>> julian 2002/11/24 13:41:42 PST >>>>> >>>>> Modified files: >>>>> sbin/fsck_ffs pass5.c >>>>> ... >>>> Please fix the style bugs (excessive parentheses) in this before merging. >>> >>> I thought there was consensus that additional parentheses were not >>> necessarily a Bad Thing if they served to demonstrate operator >>> precedence, as here. >> >> Here is a patch to fix these style bugs. >> >> ... > > I don't think anybody is in doubt about how to change it. > >> To me, parenthesizing almost eveything demonstrates that the author >> is not fluent in C. > > To me, parenthesizing demonstrates that the author thinks the reader > may not be fluent in C. If the reader is not fluent in C, the reader has many more problems to deal with than trying to figure out the order of operations when trying to read source code. This is FreeBSD, not CS 101. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message