Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 17 Oct 2023 15:55:30 GMT
From:      Mark Johnston <markj@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 56279238b03a - main - geom_linux_lvm: Avoid removing from vg_list before inserting
Message-ID:  <202310171555.39HFtU8T028970@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by markj:

URL: https://cgit.FreeBSD.org/src/commit/?id=56279238b03a0ccef245b22fff7679fe35cffccc

commit 56279238b03a0ccef245b22fff7679fe35cffccc
Author:     Mark Johnston <markj@FreeBSD.org>
AuthorDate: 2023-10-17 14:25:38 +0000
Commit:     Mark Johnston <markj@FreeBSD.org>
CommitDate: 2023-10-17 15:19:05 +0000

    geom_linux_lvm: Avoid removing from vg_list before inserting
    
    PR:             266693
    Reported by:    Robert Morris <rtm@lcs.mit.edu>
    MFC after:      1 week
---
 sys/geom/linux_lvm/g_linux_lvm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sys/geom/linux_lvm/g_linux_lvm.c b/sys/geom/linux_lvm/g_linux_lvm.c
index dddc3ae9184e..c63318fed729 100644
--- a/sys/geom/linux_lvm/g_linux_lvm.c
+++ b/sys/geom/linux_lvm/g_linux_lvm.c
@@ -512,7 +512,6 @@ g_llvm_free_vg(struct g_llvm_vg *vg)
 		LIST_REMOVE(lv, lv_next);
 		free(lv, M_GLLVM);
 	}
-	LIST_REMOVE(vg, vg_next);
 	free(vg, M_GLLVM);
 }
 
@@ -596,7 +595,8 @@ g_llvm_destroy(struct g_llvm_vg *vg, int force)
 		}
 	}
 
-	g_llvm_free_vg(gp->softc);
+	LIST_REMOVE(vg, vg_next);
+	g_llvm_free_vg(vg);
 	gp->softc = NULL;
 	g_wither_geom(gp, ENXIO);
 	return (0);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202310171555.39HFtU8T028970>