From owner-freebsd-rc@FreeBSD.ORG Tue Oct 27 06:48:57 2009 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CEA84106566B; Tue, 27 Oct 2009 06:48:57 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from mail.allbsd.org (gatekeeper-int.allbsd.org [IPv6:2001:2f0:104:e002::2]) by mx1.freebsd.org (Postfix) with ESMTP id 071568FC08; Tue, 27 Oct 2009 06:48:56 +0000 (UTC) Received: from delta.allbsd.org (p2232-ipbf2506funabasi.chiba.ocn.ne.jp [114.167.117.232]) (authenticated bits=128) by mail.allbsd.org (8.14.3/8.14.3) with ESMTP id n9R6miFu058134; Tue, 27 Oct 2009 15:48:55 +0900 (JST) (envelope-from hrs@FreeBSD.org) Received: from localhost (alph.allbsd.org [192.168.0.10]) (authenticated bits=0) by delta.allbsd.org (8.13.4/8.13.4) with ESMTP id n9R6meKR006681; Tue, 27 Oct 2009 15:48:41 +0900 (JST) (envelope-from hrs@FreeBSD.org) Date: Tue, 27 Oct 2009 15:42:57 +0900 (JST) Message-Id: <20091027.154257.185630115.hrs@allbsd.org> To: dougb@FreeBSD.org From: Hiroki Sato In-Reply-To: <4AD7B8FA.7020703@FreeBSD.org> References: <4AD3A722.9060401@FreeBSD.org> <20091015.161939.200967153.hrs@allbsd.org> <4AD7B8FA.7020703@FreeBSD.org> X-PGPkey-fingerprint: BDB3 443F A5DD B3D0 A530 FFD7 4F2C D3D8 2793 CF2D X-Mailer: Mew version 6.2.52 on Emacs 22.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="--Security_Multipart(Tue_Oct_27_15_42_57_2009_126)--" Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.95.2 at gatekeeper.allbsd.org X-Virus-Status: Clean X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.3 (mail.allbsd.org [133.31.130.32]); Tue, 27 Oct 2009 15:48:55 +0900 (JST) Cc: markm@FreeBSD.org, freebsd-rc@FreeBSD.org Subject: Re: svn commit: r197790 - head/etc X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Oct 2009 06:48:58 -0000 ----Security_Multipart(Tue_Oct_27_15_42_57_2009_126)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Hi Doug, sorry again for the delayed response. I have been distracted by a busy few weeks due to my day job... Doug Barton wrote in <4AD7B8FA.7020703@FreeBSD.org>: do> > I noticed there was something wrong about ${name}_program but it do> > seems I mistakenly changed it (sorry...). Then I received a report do> > "it does not work" so I just reverted it. do> do> Understood. I am sure you realize that it's always Ok to ask for help do> here on -rc. The rc.d system is not life-threateningly complex but it do> does have a lot of "behind the scenes" interactions that are not do> always obvious. I certainly don't hesitate to ask for review on do> changes myself and I encourage others to do so (as you have done in do> the past). do> do> FWIW, what I do object to about your changes in r197144 and r197790 do> are that in the first case you neglected to mention that you were do> changing that part of the code, and in the second you neglected to do> mention that you were changing it back to what it was before you do> changed it. That made debugging this problem more difficult for me do> than (I think) it should have been. You also did not mention that you do> were removing $command in your changes to route[6]d, which made do> debugging Mark's original complaint harder, but only for about 30 do> seconds or so. :) Yes, indeed. I should have been more careful and will keep it in mind. Sorry about that. do> I'm sort of ambivalent about whether we need to continue encouraging do> people to use command in the script or not. As long as what's in the do> script matches what's in /etc/defaults/rc.conf we're not hurting do> anything, although we are duplicating effort. do> do> My preference at this point is to let the change that I just made do> settle for a while, mostly to see if it has any negative interactions do> with scripts from ports, then MFC it after 8.0-RELEASE along with the do> changes you've made to the IPv6 stuff. After that we can start talking do> about ripping command= out of the individual rc.d scripts if people do> think that's a good idea. Sounds reasonable to me. -- Hiroki ----Security_Multipart(Tue_Oct_27_15_42_57_2009_126)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEABECAAYFAkrmlnIACgkQTyzT2CeTzy0QhQCg2NBG/ToxfOGdhEURk2haLn76 OQ0AoIr2mqcgjYxL+4xKEh3IIhHAM8cX =QhDQ -----END PGP SIGNATURE----- ----Security_Multipart(Tue_Oct_27_15_42_57_2009_126)----