From owner-freebsd-current@FreeBSD.ORG Wed May 19 05:40:47 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DDE5A16A4CE for ; Wed, 19 May 2004 05:40:47 -0700 (PDT) Received: from mail4.speakeasy.net (mail4.speakeasy.net [216.254.0.204]) by mx1.FreeBSD.org (Postfix) with ESMTP id AA04043D1F for ; Wed, 19 May 2004 05:40:47 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 12958 invoked from network); 19 May 2004 12:40:38 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 19 May 2004 12:40:38 -0000 Received: from slimer.baldwin.cx (slimer.baldwin.cx [192.168.0.16]) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id i4JCea2Z061576; Wed, 19 May 2004 08:40:36 -0400 (EDT) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: thierry@herbelot.com Date: Wed, 19 May 2004 08:13:38 -0400 User-Agent: KMail/1.6 References: <200405182105.04275.thierry@herbelot.com> In-Reply-To: <200405182105.04275.thierry@herbelot.com> MIME-Version: 1.0 Content-Disposition: inline Message-Id: <200405190813.23919.jhb@FreeBSD.org> Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: current ML Subject: Re: [long] panic on a recent current X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 May 2004 12:40:48 -0000 On Tuesday 18 May 2004 03:05 pm, Thierry Herbelot wrote: > on a recent -current, running KDE and simultaneously building the world. > > As the machine is quite slow, I post this message "raw" (further in the > message : a gdb session and the full dmesg) > I'm trying to reproduce the panic. > The kernel config file is the straight "GENERIC". Here is a possible fix: Index: kern_sig.c =================================================================== RCS file: /usr/cvs/src/sys/kern/kern_sig.c,v retrieving revision 1.276 diff -u -r1.276 kern_sig.c --- kern_sig.c 12 Apr 2004 15:56:05 -0000 1.276 +++ kern_sig.c 19 May 2004 12:10:47 -0000 @@ -1953,7 +1953,7 @@ td->td_priority = PUSER; } } - if (TD_IS_SLEEPING(td)) { + if (TD_ON_SLEEPQ(td)) { /* * If thread is sleeping uninterruptibly * we can't interrupt the sleep... the signal will All the other callers check TD_ON_SLEEPQ() rather than TD_IS_SLEEPING() before calling sleepq_abort(). A thread can be marked sleeping w/o being on a sleep queue during the timed sleepq race workaround. Also, for what it's worth, 4.x's psignal() doesn't do an unsleep() in the case that this code does. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org