From owner-cvs-all@FreeBSD.ORG Tue Oct 19 00:55:42 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D024116A4CE; Tue, 19 Oct 2004 00:55:42 +0000 (GMT) Received: from daintree.corp.yahoo.com (daintree.corp.yahoo.com [216.145.52.172]) by mx1.FreeBSD.org (Postfix) with ESMTP id BAA8043D2F; Tue, 19 Oct 2004 00:55:37 +0000 (GMT) (envelope-from peter@yahoo-inc.com) Received: by daintree.corp.yahoo.com (Postfix, from userid 2154) id ABE0A1C754; Mon, 18 Oct 2004 17:55:37 -0700 (PDT) From: Peter Wemm To: "Andrey A. Chernov" Date: Mon, 18 Oct 2004 17:55:37 -0700 User-Agent: KMail/1.6.2 References: <200410180836.i9I8afRS060144@repoman.freebsd.org> In-Reply-To: <200410180836.i9I8afRS060144@repoman.freebsd.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200410181755.37423.peter@wemm.org> cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/gnu/lib/libreadline/readline Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 00:55:43 -0000 On Monday 18 October 2004 01:36 am, Andrey A. Chernov wrote: > ache 2004-10-18 08:36:40 UTC > > FreeBSD src repository > > Modified files: > gnu/lib/libreadline/readline Makefile > Log: > Back out termcap -> ncurses change in LDADD/DPADD > It expand functions scope too wide No. This is wrong, and a NOP change. Please back this out. The reason why is because libtermcap.so is a symlink to libncurses. And libncurses has a DT_SONAME of "libncurses.so.5". This means peter@daintree[5:51pm]~-25> objdump --all-headers /usr/lib/libtermcap.so | grep SONAME SONAME libncurses.so.5 Any dependencies will be silently "fixed" by ld, so no matter what, you end up with a DT_NEEDED of libncurses.so.5. Except that by using the wrong name, you obfuscate things. peter@daintree[5:53pm]~-30> cc -o x x.c -ltermcap peter@daintree[5:53pm]~-31> objdump --all-headers x | grep NEED NEEDED libncurses.so.5 NEEDED libc.so.5 peter@daintree[5:53pm]~-32> cc -shared -o x.so x.c -ltermcap peter@daintree[5:53pm]~-33> objdump --all-headers x.so | grep NEED NEEDED libncurses.so.5 -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5