From owner-freebsd-rc@FreeBSD.ORG Fri Nov 18 21:11:31 2011 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A63631065670 for ; Fri, 18 Nov 2011 21:11:31 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from anubis.delphij.net (anubis.delphij.net [IPv6:2001:470:1:117::25]) by mx1.freebsd.org (Postfix) with ESMTP id 8A5248FC24 for ; Fri, 18 Nov 2011 21:11:31 +0000 (UTC) Received: from delta.delphij.net (drawbridge.ixsystems.com [206.40.55.65]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by anubis.delphij.net (Postfix) with ESMTPSA id E1E5D63F7; Fri, 18 Nov 2011 13:11:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=delphij.net; s=anubis; t=1321650691; bh=OcvaNP76dX0GotbbcSIwR45rW6rY9KV+dJ9yR4qsGg0=; h=Message-ID:Date:From:Reply-To:MIME-Version:To:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=hFqjkQaXbA4DrbOZ+HgMp/W+T+nDiYevUehGlZ0fh4CmqufGxjoAcGQ1PX1VtFm1J 0WaiNTGXaj98i35QGnjubpwH+HNu64bYugwvLJ1n+xXoEsJlMufx4/7Zk6p/Tg4O7J uMLFAeY3zwitsMugmVH99QxzS2yg/EMFOYUJNSI0= Message-ID: <4EC6CA02.5090606@delphij.net> Date: Fri, 18 Nov 2011 13:11:30 -0800 From: Xin LI Organization: The FreeBSD Project MIME-Version: 1.0 To: freebsd-rc@freebsd.org References: <4EB6693F.2020102@delphij.net> <4EB71580.20507@FreeBSD.org> <4EB72290.8030104@delphij.net> <4EC6C247.6040807@delphij.net> <4EC6C50F.30405@FreeBSD.org> In-Reply-To: <4EC6C50F.30405@FreeBSD.org> OpenPGP: id=3FCA37C1; url=http://www.delphij.net/delphij.asc Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: Annoying ERROR: 'wlan0' is not a DHCP-enabled interface X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: d@delphij.net List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Nov 2011 21:11:31 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 11/18/11 12:50, Doug Barton wrote: > On 11/18/2011 12:45, Eygene Ryabinkin wrote: >> Xin, good day. >> >> Fri, Nov 18, 2011 at 12:38:31PM -0800, Xin LI wrote: >>> Is there any counter reasoning about "having an interface >>> marked as non-DHCP is not an error"? I'm still not convinced >>> with the benefit of having it show an error message. >> >> Well, when I invoke 'service dhclient start em0' and em0 isn't >> DHCP-enabled, I want to see some diagnostics on why I was not >> able to get DHCP on that interface. Return code isn't that >> visible (I can, of course, always run it as 'service dhclient >> start em0 || echo failed'), but I am not up to typing more than >> needed and I should see the real reason for absence of >> DHCP-assigned address in that case, be it the non-DHCP-enabled >> interface or some other problem. > > Right, that's my argument as well. > > If there is a particular code path that leads to attempting > dhclient on a non-dhcp interface I'd rather see that code path > fixed than to suppress the warning. Do you have any objection to rea@'s version of patch? I think it's sensible that quietstart shouldn't issue this type of warnings. Cheers, - -- Xin LI https://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (FreeBSD) iQEcBAEBCAAGBQJOxsoCAAoJEATO+BI/yjfB7WMH/iGw2An8lFBSdDYlHhwvmypK Dy5UPSy9EeRH8WEXkGT+m8pAQEoYgPTbuDCXekrOgicQyG4+1TxtTGncjGKKm7s/ ZiviK4Sl7l4zD0fqxMA9kJiaMGYslrLX8dRTfhbwO/lmweRk2Eg44ODDyla6SDI8 T/9pINNR7nBcOAWJltdY/ZtofQydj0EWLFX8v2xL0wBTS9DyLL9Bog878LEzfxYJ ddquA9Frea/8kMsS8sc48dZts1o6DwQ+9oQeOTsYfHqpHznekdNXlZgbkQQI/vYg rtMw0p6mC3jw6jpi+zWavI+IuOlzPstpipVZntl8h/sCq6ZCqL8VjXgE7Y+LBPw= =9v4a -----END PGP SIGNATURE-----