From owner-svn-src-head@freebsd.org Fri Sep 11 05:42:03 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D1056A013F6; Fri, 11 Sep 2015 05:42:03 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id C50D51B76; Fri, 11 Sep 2015 05:42:03 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id C3A60106C; Fri, 11 Sep 2015 05:42:03 +0000 (UTC) Date: Fri, 11 Sep 2015 05:42:03 +0000 From: Alexey Dokuchaev To: Devin Teske Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r287635 - in head/release: amd64 i386 pc98 powerpc sparc64 Message-ID: <20150911054203.GA92046@FreeBSD.org> References: <201509102247.t8AMlRA5039170@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201509102247.t8AMlRA5039170@repo.freebsd.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Sep 2015 05:42:03 -0000 On Thu, Sep 10, 2015 at 10:47:27PM +0000, Devin Teske wrote: > New Revision: 287635 > URL: https://svnweb.freebsd.org/changeset/base/287635 > > Log: > Fix argument quoting and remove unnecessary braces > [...] > > if [ $# -lt 3 ]; then > - echo Usage: $0 '[-b] image-label image-name base-bits-dir [extra-bits-dir]' > + echo "Usage: $0 [-b] image-label image-name base-bits-dir [extra-bits-dir]" usage() output typically should be sent to stderr, i.e." echo "usage: $0 bla-bla-bla" >&2 (this bug exists in all those scripts). ./danfe