From owner-cvs-all Tue Jan 12 13:36:42 1999 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id NAA14358 for cvs-all-outgoing; Tue, 12 Jan 1999 13:36:42 -0800 (PST) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from cimlogic.com.au (cimlog.lnk.telstra.net [139.130.51.31]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id NAA14346; Tue, 12 Jan 1999 13:36:31 -0800 (PST) (envelope-from jb@cimlogic.com.au) Received: (from jb@localhost) by cimlogic.com.au (8.9.1/8.9.1) id IAA08522; Wed, 13 Jan 1999 08:37:34 +1100 (EST) (envelope-from jb) From: John Birrell Message-Id: <199901122137.IAA08522@cimlogic.com.au> Subject: Re: cvs commit: src/sys/netinet ip_input.c In-Reply-To: <199901122124.NAA07208@bubba.whistle.com> from Archie Cobbs at "Jan 12, 1999 1:24:53 pm" To: archie@whistle.com (Archie Cobbs) Date: Wed, 13 Jan 1999 08:37:34 +1100 (EST) Cc: mike@smith.net.au, eivind@FreeBSD.ORG, luigi@labinfo.iet.unipi.it, cvs-committers@FreeBSD.ORG X-Mailer: ELM [version 2.4ME+ PL43 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk Archie Cobbs wrote: > Mike Smith writes: > > > Unless good counter-arguments spring forward, -Werror is going in > > > shortly, so tolerating the warnings is not an option. > > > > -Werror is anal fluff. I applaud it being the default for general > > usage, but -Werror made working on NetBSD *extremely* difficult. > > Stamping out warnings is desirable, but sometimes the crud in the code > > required to do it is worse than the warning. > > This is not a counter-argument, only a report from my personal > experience. > > To me the gcc warnings are *essential* to producing bug-free code > in a timely manner. Therefore, getting to -Werror is a good goal. > > While there are weird corner cases where a warning may be unavoidable, > gcc provides mechanisms to deal with these (like our __dead and __unused). > > So IMHO it's pretty vanishingly rare that -Werror is impossible to achieve. If you are working on a "problem child" in the tree and in doing so you choose to compile without optimisation, your build is likely to fail due to -Werror barfing on static inline definitions in the headers that aren't used. This is *really* annoying. I removed -Werror from a couple of places in the tree when porting stuff to alpha because of this. If people want to _add_ -Werror in their local /etc/make.conf, by all means do so, but please don't make it required. -- John Birrell - jb@cimlogic.com.au; jb@freebsd.org http://www.cimlogic.com.au/ CIMlogic Pty Ltd, GPO Box 117A, Melbourne Vic 3001, Australia +61 418 353 137 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message