From owner-freebsd-stable Tue Mar 13 20:10:40 2001 Delivered-To: freebsd-stable@freebsd.org Received: from mukappa.home.com (c576194-a.saltlk1.ut.home.com [65.5.60.246]) by hub.freebsd.org (Postfix) with ESMTP id 644C737B718 for ; Tue, 13 Mar 2001 20:10:36 -0800 (PST) (envelope-from mupi@mknet.org) Received: from mukappa.home.com (localhost.home.com [127.0.0.1]) by mukappa.home.com (8.11.1/8.11.1) with SMTP id f2E45K926594; Tue, 13 Mar 2001 21:05:20 -0700 (MST) (envelope-from mupi@mknet.org) From: Mike Porter Reply-To: mupi@mknet.org To: j mckitrick , Ian Dowse Subject: Re: suspend/restore with ppp connections Date: Tue, 13 Mar 2001 21:05:17 -0700 X-Mailer: KMail [version 1.1.99] Content-Type: text/plain; charset="us-ascii" Cc: Alfred Perlstein , freebsd-stable@FreeBSD.ORG References: <20010312135826.F86948@dogma.freebsd-uk.eu.org> <200103121440.aa97105@salmon.maths.tcd.ie> <20010312145622.A87895@dogma.freebsd-uk.eu.org> In-Reply-To: <20010312145622.A87895@dogma.freebsd-uk.eu.org> MIME-Version: 1.0 Message-Id: <01031321051700.26413@mukappa.home.com> Content-Transfer-Encoding: 8bit Sender: owner-freebsd-stable@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Monday 12 March 2001 07:56, j mckitrick wrote: > | The problem is that the card has been reattached, so com->gone is > | 0. However com->tp is NULL because the driver has not seen an open() > | since attachment. It would probably be possible to add a few tests > | for com->tp != NULL in a few places, but sio.c has bigger problems > | in this area. It seems that a struct tty will be leaked for every > | insert/removal too. There is also a missing call to the line > | discipline's l_close function in the forced detach case. > > Now this is the kind of thing I would be interested in helping fix. But if > you say sio has bigger problems, I might be in over my head. What would > happen if I just added those tests for NULL? > Maybe it's just me, but why don't you just add into /etc/rc.suspend code to ring down the ppp connection? (which is more or less what windoze does to get around the pitfalls involved....) mike -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.3 (FreeBSD) Comment: For info see http://www.gnupg.org iEYEARECAAYFAjqu7gAACgkQZ7GovTQbIm7bnwCfddTH2lWmLvKUmo1mxYsefaia jDsAn34931du7dxHyFyuMahq2xFn6C7E =9wXy -----END PGP SIGNATURE----- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message