From owner-cvs-all Wed Jun 6 15:50: 9 2001 Delivered-To: cvs-all@freebsd.org Received: from bazooka.unixfreak.org (bazooka.unixfreak.org [63.198.170.138]) by hub.freebsd.org (Postfix) with ESMTP id 96B8C37B401; Wed, 6 Jun 2001 15:50:00 -0700 (PDT) (envelope-from dima@unixfreak.org) Received: from hornet.unixfreak.org (hornet [63.198.170.140]) by bazooka.unixfreak.org (Postfix) with ESMTP id 3CE163E0B; Wed, 6 Jun 2001 15:49:51 -0700 (PDT) To: cvs-committers@Freebsd.org, cvs-all@Freebsd.org Subject: Re: cvs commit: src/sys/kern tty_snoop.c src/sys/sys snoop.h In-Reply-To: <20010605013747.A49295@dragon.nuxi.com>; from obrien@Freebsd.org on "Tue, 5 Jun 2001 01:37:47 -0700" Date: Wed, 06 Jun 2001 15:49:51 -0700 From: Dima Dorfman Message-Id: <20010606224951.3CE163E0B@bazooka.unixfreak.org> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG "David O'Brien" writes: > On Tue, Jun 05, 2001 at 10:21:49AM +0300, Ruslan Ermilov wrote: > > > > Log: > > > > Style and cosmetic cleanups. This driver is now reasonably stlye(9) > > > > compliant. All the variable definitions and function names are > > > > reasonably consistent, and the functions which should be static (i.e. > , > > > > all of them) are. Other assorted fixes were made. The majority of > > > > the delta is indentation fixes. > > > > > > In my ever so humble opinion it's better to do the whitespace commits > > > seperately. That makes it much easier to see the substantive changes. > > > > > cvs diff -w? > > Regardless, it is our practice to commit style/cosmetic changes by > themselves with no functionality changes mixed in (and vice-versa). Perhaps you misunderstood my commit message. There were no functional changes in this commit. I fixed indentation, changes a few function names to be consistent, removed initializers on automatic variables (e.g., "int error = 0;" -> "int error; error = 0;"), and made a few other style fixes (e.g., "return n;" -> "return (n);"). No new code was added. The delta does produce a different object file because some of the changes (such as moving initializers) may cause different code to be produced. My understanding of the logic behind that rule is that we want to be able to see bugfixes and new features using 'diff'; since this commit doesn't add any new features or fix any bugs, I think it may qualify as pure "style/cosmetic". Dima Dorfman dima@unixfreak.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message