From owner-freebsd-current@FreeBSD.ORG  Fri Jun 29 17:28:42 2012
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 9F5A0106566B;
	Fri, 29 Jun 2012 17:28:42 +0000 (UTC)
	(envelope-from gnn@neville-neil.com)
Received: from vps.hungerhost.com (vps.hungerhost.com [216.38.53.176])
	by mx1.freebsd.org (Postfix) with ESMTP id 6EF1E8FC08;
	Fri, 29 Jun 2012 17:28:42 +0000 (UTC)
Received: from [209.249.190.124] (port=58309 helo=gnnmac.hudson-trading.com)
	by vps.hungerhost.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.77)
	(envelope-from <gnn@neville-neil.com>)
	id 1Skeyr-0007xu-2u; Fri, 29 Jun 2012 13:27:41 -0400
Mime-Version: 1.0 (Apple Message framework v1280)
Content-Type: text/plain; charset=us-ascii
From: George Neville-Neil <gnn@neville-neil.com>
In-Reply-To: <20120626210606.632498e2@fabiankeil.de>
Date: Fri, 29 Jun 2012 13:27:26 -0400
Content-Transfer-Encoding: 7bit
Message-Id: <5993D573-4D53-44F5-BE8F-C48E9816398B@neville-neil.com>
References: <4FE9EFF9.9080507@FreeBSD.org>
	<1340735734.53528.YahooMailClassic@web113510.mail.gq1.yahoo.com>
	<20120626210606.632498e2@fabiankeil.de>
To: Fabian Keil <freebsd-listen@fabiankeil.de>
X-Mailer: Apple Mail (2.1280)
X-AntiAbuse: This header was added to track abuse,
	please include it with any abuse report
X-AntiAbuse: Primary Hostname - vps.hungerhost.com
X-AntiAbuse: Original Domain - freebsd.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - neville-neil.com
Cc: Mark Peek <mp@FreeBSD.org>, freebsd-current@FreeBSD.org, pfg@freebsd.org
Subject: Re: [RFT] llquantize for FreeBSD's dtrace
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Jun 2012 17:28:42 -0000


On Jun 26, 2012, at 15:06 , Fabian Keil wrote:

> Pedro Giffuni <pfg@freebsd.org> wrote:
> 
>> --- Mar 26/6/12, Mark Peek <mp@FreeBSD.org> ha scritto:
> 
>>> Try this, change the assert on line 1429 in file dt_cc.c
>>> from:
>>> 
>>> assert(!(arg & (UINT16_MAX << args[i].shift)));
>>> 
>>> to
>>> 
>>> assert(!(arg & ((uint64_t)UINT16_MAX <<
>>> args[i].shift)));
>>> 
>> 
>> This certainly looks correct. Thanks Mark !
>> 
>> I updated the patch:
>> 
>> http://people.freebsd.org/~pfg/patches/patch-dtrace-llquantize
> 
> Thanks a lot. Seems to work for me:
> 

And me as well.  I tested the example from the web site.

Nicely done!

Best,
George