From owner-freebsd-current@FreeBSD.ORG Sun Oct 2 11:25:31 2005 Return-Path: X-Original-To: current@freebsd.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0966516A41F for ; Sun, 2 Oct 2005 11:25:31 +0000 (GMT) (envelope-from kometen@gmail.com) Received: from wproxy.gmail.com (wproxy.gmail.com [64.233.184.205]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4B6FE43D46 for ; Sun, 2 Oct 2005 11:25:30 +0000 (GMT) (envelope-from kometen@gmail.com) Received: by wproxy.gmail.com with SMTP id i21so81569wra for ; Sun, 02 Oct 2005 04:25:27 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=LRYONPwpCRO4lIKcLKycSor03BFjJgNSD90abJHeabgcsz5CHQEQ7MctpnczFbbGSYqSAvtkrQAxJJ+ILue7nL3DDVYj/NZJYhlD8JakkO21lBd1SJd87hK1+jqqYbgf0Fy9JjtEVy6LsJZSw9c7pfcL1WoZF5zGvk9oHILr6TY= Received: by 10.54.120.8 with SMTP id s8mr554214wrc; Sun, 02 Oct 2005 04:25:27 -0700 (PDT) Received: by 10.54.144.4 with HTTP; Sun, 2 Oct 2005 04:25:27 -0700 (PDT) Message-ID: Date: Sun, 2 Oct 2005 13:25:27 +0200 From: Claus Guttesen To: Don Lewis In-Reply-To: <200510020908.j9298dAX014736@gw.catspoiler.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <200510020908.j9298dAX014736@gw.catspoiler.org> Cc: current@freebsd.org Subject: Re: patch review & testing request for fill_kinfo_proc() and friends X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Claus Guttesen List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Oct 2005 11:25:31 -0000 2005/10/2, Don Lewis : > Attached is a patch that fixes locking problems in fill_kinfo_proc() and > related functions. The patch is larger than I initially anticipated > because I had to refactor the code in order to get the locking right. > > I'd like to commit it to HEAD soon so that it can be MFC'ed in time for > 6.0-RC1, but it really needs review and testing of all the sysctl and > linprocfs functionality. This patch also applies cleanly to RELENG_6. Applied the patch from RELENG_6 from Sunday Oct. 2'nd. twin/usr/src/sys/kern#>patch < /home/claus/temp/fifo_patch Hmm... Looks like a unified diff to me... The text leading up to this was: -------------------------- |Index: kern_proc.c |=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D |RCS file: /home/ncvs/src/sys/kern/kern_proc.c,v |retrieving revision 1.231 |diff -u -r1.231 kern_proc.c |--- kern_proc.c 27 Sep 2005 18:03:15 -0000 1.231 |+++ kern_proc.c 2 Oct 2005 08:48:56 -0000 -------------------------- Patching file kern_proc.c using Plan A... Hunk #1 succeeded at 72 (offset -1 lines). Hunk #2 failed at 597. Hunk #3 failed at 674. Hunk #4 failed at 728. Hunk #5 succeeded at 738 with fuzz 1 (offset 2 lines). Hunk #6 failed at 886. Hunk #7 failed at 949. 5 out of 7 hunks failed--saving rejects to kern_proc.c.rej Hmm... Ignoring the trailing garbage. done regards Claus