From owner-cvs-src@FreeBSD.ORG Sat Dec 17 18:29:06 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A490E16A41F; Sat, 17 Dec 2005 18:29:06 +0000 (GMT) (envelope-from nate@root.org) Received: from ylpvm12.prodigy.net (ylpvm12-ext.prodigy.net [207.115.57.43]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5ED7643D49; Sat, 17 Dec 2005 18:29:04 +0000 (GMT) (envelope-from nate@root.org) Received: from pimout5-ext.prodigy.net (pimout5-int.prodigy.net [207.115.4.21]) by ylpvm12.prodigy.net (8.12.10 outbound/8.12.10) with ESMTP id jBHIT2KI002376; Sat, 17 Dec 2005 13:29:03 -0500 X-ORBL: [71.139.30.140] Received: from [10.0.5.50] (ppp-71-139-30-140.dsl.snfc21.pacbell.net [71.139.30.140]) by pimout5-ext.prodigy.net (8.13.4 outbound domainkey aix/8.13.4) with ESMTP id jBHISxO2076396; Sat, 17 Dec 2005 13:29:01 -0500 Message-ID: <43A547F2.2090401@root.org> Date: Sun, 18 Dec 2005 03:28:50 -0800 From: Nate Lawson User-Agent: Mozilla Thunderbird 1.0.6 (X11/20050723) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Scott Long Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/sys ktr.h src/sys/kern kern_clock.c kern_switch.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Dec 2005 18:29:06 -0000 Scott Long wrote: > Nate Lawson wrote: > > >>njl 2005-12-17 03:57:10 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/sys ktr.h >> sys/kern kern_clock.c kern_switch.c >> Log: >> Clean up unused or poorly utilized KTR values. Remove KTR_FS, KTR_KGDB, >> and KTR_IO as they were never used. Remove KTR_CLK since it was only >> used for hardclock firing and use KTR_INTR there instead. Remove >> KTR_CRITICAL since it was only used for crit enter/exit and use >> KTR_CONTENTION instead. >> >> Revision Changes Path >> 1.183 +1 -1 src/sys/kern/kern_clock.c >> 1.118 +2 -2 src/sys/kern/kern_switch.c >> 1.35 +12 -12 src/sys/sys/ktr.h > > > Um, I was using KTR_CRITICAL for schedgraph. It was actually quite > useful. Compressing the option space only makes the options less > useful. Surely there has to be a better solution. Or, at least you > could call for comments before you alter this stuff. You didn't speak up about that in the previous discussion on arch@, starting 10/31/2005. The only comment was jhb@ saying it was not useful alone, and he's the only one doing work on critical sections lately. If you can think of another use for this besides one event (enter/exit), feel free to add it back. Or, consider adding KTR_SUBSYS as a one-off use like KTR_DEV is for other parts of the system. KTR_CRITICAL would be conditionally defined as KTR_SUBSYS when needed. -- Nate