From owner-freebsd-ports@FreeBSD.ORG Fri Nov 22 14:12:47 2013 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1B0CCAA6 for ; Fri, 22 Nov 2013 14:12:47 +0000 (UTC) Received: from mail.server1.bsdforen.de (bsdforen.de [82.193.243.81]) by mx1.freebsd.org (Postfix) with ESMTP id CCBA926EB for ; Fri, 22 Nov 2013 14:12:46 +0000 (UTC) Received: from mobileKamikaze.norad (MN-VPN2.HS-Karlsruhe.DE [193.196.117.63]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mail.server1.bsdforen.de (Postfix) with ESMTPSA id 11B1E861EB; Fri, 22 Nov 2013 15:12:43 +0100 (CET) Message-ID: <528F665A.3070305@bsdforen.de> Date: Fri, 22 Nov 2013 15:12:42 +0100 From: Dominic Fandrey MIME-Version: 1.0 To: Kimmo Paasiala , FreeBSD Ports , Eitan Adler Subject: Re: DESTDIR support broken? References: <52850FBA.9010308@bsdforen.de> <5289CA5E.3010103@bsdforen.de> <528BA37E.4030308@bsdforen.de> <528F55E4.3040602@bsdforen.de> <20131122131727.GB7437@straylight.m.ringlet.net> In-Reply-To: <20131122131727.GB7437@straylight.m.ringlet.net> Content-Type: text/plain; charset=ascii Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Nov 2013 14:12:47 -0000 On 22/11/2013 14:17, Peter Pentchev wrote: > On Fri, Nov 22, 2013 at 02:02:28PM +0100, Dominic Fandrey wrote: >> On 19/11/2013 18:44, Dominic Fandrey wrote: >>> On 18/11/2013 20:28, Kimmo Paasiala wrote: >>>> On Mon, Nov 18, 2013 at 10:05 AM, Dominic Fandrey wrote: >>>>> On 18/11/2013 04:10, Eitan Adler wrote: >>>>>> On Thu, Nov 14, 2013 at 1:00 PM, Dominic Fandrey wrote: >>>>>>> # make DESTDIR=/root/tmpdest install >>>>>>> ===> Creating some important subdirectories >>>>>> >>>>>> Are you sure you don't mean "make PREFIX=/root/tmpdest/" ? >>>>> >>>>> Yes. >>>>> >>>>> -- >>>> >>>> I would expect DESTDIR=/some/path just work for any port. Last commit >>>> to bsd.destdir was over a year ago so either it has been broken for a >>>> long time or some other more recent commit has broken it. >>> >>> /root/tmpdest is a complete FreeBSD chroot (I did a >>> "make installworld distribution DESTDIR=/root/tmpdest" right beforehand). >>> >>> I tried several ports, they all exhibit the same failure. >> >> The issue is that BSD make (in stable/10) passes "set -e" to the shell >> by default. >> >> I submitted the details and a fix: >> http://www.freebsd.org/cgi/query-pr.cgi?pr=184170 > > Hmm, even if this is so, I wonder if there would not be another funny > problem later: for ports that actually use staging, ... I tested the fix with a port that I just converted to staging. No problems there. The staging happens on the host system, but the resulting package is correctly installed into DESTDIR. -- A: Because it fouls the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing on usenet and in e-mail?