Date: Wed, 11 Oct 2000 10:37:50 -0700 (PDT) From: Archie Cobbs <archie@whistle.com> To: Ruslan Ermilov <ru@FreeBSD.ORG> Cc: itojun@iijlab.net, Luigi Rizzo <luigi@info.iet.unipi.it>, Archie Cobbs <archie@whistle.com>, bmilekic@FreeBSD.ORG, freebsd-net@FreeBSD.ORG, Garrett Wollman <wollman@FreeBSD.ORG> Subject: Re: ip_input.c patch Message-ID: <200010111737.e9BHboe45566@bubba.whistle.com> In-Reply-To: <20001011110132.D56373@sunbay.com> "from Ruslan Ermilov at Oct 11, 2000 11:01:32 am"
next in thread | previous in thread | raw e-mail | index | archive | help
Ruslan Ermilov writes: > > >don't think there is much need for that... ip_len and ip_off are > > >mostly or probably only used in ip_input() and there you just need > > >to fetch&swap a copy of the value into a local variable on entry > > >and use the local variable afterwards. Even better for ip_id which > > >is only used for equality comparisons... > > > > while i 100% agree that we should not swap bytes in ip_input, > > we need to be very sure to preserve (strange) byte ordering constraint > > in raw ip socket (IP_HDRINCL)... so be careful. > > > If noone objects, I will prepare the patch that avoids byte-swapping for > ip_len and ip_off (I have recently done a similar thing for ip_id). That would be great (assuming it gets reviewed by -net). -Archie ___________________________________________________________________________ Archie Cobbs * Whistle Communications, Inc. * http://www.whistle.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200010111737.e9BHboe45566>