From owner-freebsd-pf@FreeBSD.ORG  Tue Jan 29 21:20:03 2008
Return-Path: <owner-freebsd-pf@FreeBSD.ORG>
Delivered-To: freebsd-pf@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id CD73D16A41A
	for <freebsd-pf@hub.freebsd.org>; Tue, 29 Jan 2008 21:20:03 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id BA22313C447
	for <freebsd-pf@hub.freebsd.org>; Tue, 29 Jan 2008 21:20:03 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m0TLK3xl087306
	for <freebsd-pf@freefall.freebsd.org>; Tue, 29 Jan 2008 21:20:03 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m0TLK3TC087305;
	Tue, 29 Jan 2008 21:20:03 GMT (envelope-from gnats)
Date: Tue, 29 Jan 2008 21:20:03 GMT
Message-Id: <200801292120.m0TLK3TC087305@freefall.freebsd.org>
To: freebsd-pf@FreeBSD.org
From: "=?ISO-8859-1?Q?Ermal_Lu=E7i?=" <ermal.luci@gmail.com>
Cc: 
Subject: Re: kern/120057: [patch] Allow proper settings of ALTQ_HFSC. The
	check i wrong since even with the values forbidden from this
	check you get a concave curve.
X-BeenThere: freebsd-pf@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: =?ISO-8859-1?Q?Ermal_Lu=E7i?= <ermal.luci@gmail.com>
List-Id: "Technical discussion and general questions about packet filter
	\(pf\)" <freebsd-pf.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-pf>,
	<mailto:freebsd-pf-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-pf>
List-Post: <mailto:freebsd-pf@freebsd.org>
List-Help: <mailto:freebsd-pf-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-pf>,
	<mailto:freebsd-pf-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Jan 2008 21:20:03 -0000

The following reply was made to PR kern/120057; it has been noted by GNATS.

From: "=?ISO-8859-1?Q?Ermal_Lu=E7i?=" <ermal.luci@gmail.com>
To: "Max Laier" <max@love2party.net>
Cc: bug-followup@freebsd.org, eri@freebsd.org
Subject: Re: kern/120057: [patch] Allow proper settings of ALTQ_HFSC. The check i wrong since even with the values forbidden from this check you get a concave curve.
Date: Tue, 29 Jan 2008 22:11:32 +0100

 Following up, since i noticed that the mail was truncated.
 
 Also not that the link you gave me, has the note:
 <snip>
 In order to decouple delay and bandwidth allocation, HFSC is designed
 based on the service curve service model. In HFSC, only two-piece
 linear service curves are used for simplicity. A two-piece linear
 service curve is characterized by three parameters:
 
    * m1, the slope of the first segment
    * m2, the slope of the second segment
    * d, the x-projection of the intersection point of the two segments
 
 The following figure illustrates the two types of two-piece linear
 service curves used in HFSC. For a convex curve (when m1 is less than
 m2), m1 is always zero.
 </snip>
 
 But beware, that m1 here is in slope terms while m1 parameter of
 service curves is not a slope! It is bytes per tick.
 To check if a curve is concave, in the paper there is a proper formula
 but needs some info that is not available at configuration time. But
 as i said you cannot really configure a convex service curve.