From owner-cvs-all  Tue Feb  5 15:26:21 2002
Delivered-To: cvs-all@freebsd.org
Received: from patrocles.silby.com (d179.as0.nwbl0.wi.voyager.net [169.207.130.181])
	by hub.freebsd.org (Postfix) with ESMTP
	id A535637B41E; Tue,  5 Feb 2002 15:26:14 -0800 (PST)
Received: from localhost (silby@localhost)
	by patrocles.silby.com (8.11.6/8.11.6) with ESMTP id g15HT3b03404;
	Tue, 5 Feb 2002 17:29:14 GMT
	(envelope-from silby@silby.com)
X-Authentication-Warning: patrocles.silby.com: silby owned process doing -bs
Date: Tue, 5 Feb 2002 17:29:03 +0000 (GMT)
From: Mike Silbersack <silby@silby.com>
To: "Andrey A. Chernov" <ache@nagual.pp.ru>
Cc: Alfred Perlstein <bright@mu.org>, Mark Murray <mark@grondar.za>,
	<des@freebsd.org>, <cvs-committers@freebsd.org>,
	<cvs-all@freebsd.org>
Subject: Re: cvs commit: src/lib/libpam/modules/pam_unix pam_unix.c
In-Reply-To: <20020205231832.GA9856@nagual.pp.ru>
Message-ID: <20020205172650.R1617-100000@patrocles.silby.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG


On Wed, 6 Feb 2002, Andrey A. Chernov wrote:

> On Tue, Feb 05, 2002 at 15:15:40 -0800, Alfred Perlstein wrote:
> > >
> > > BTW, to clarify my position: I not insist on using arc4random(), I insist
> > > on removing random(). You can replace arc4random() with any fastest code
> > > you wants.
> >
> > to address the speed issue you could implement internal functions to
> > save and restore the random() state.  (as I've already suggested)
>
> Yes, I agree with this solution, if 3-4 times slowness for 14 calls plays
> any role. But current variant is not acceptable and must be fixed somehow.
>
> --
> Andrey A. Chernov
> http://ache.pp.ru/

This argument is getting really ridiculous, guys.

When generating syn-acks, we either do a arc4random or a MD5, depending on
how the system is configured.  I think the performance of pam modules
using arc4random will be just fine.  Please use it.

Mike "Silby" Silbersack


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message