From owner-freebsd-ports-bugs@FreeBSD.ORG  Tue Dec 14 11:26:05 2004
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 7D20616A4CE; Tue, 14 Dec 2004 11:26:05 +0000 (GMT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 6A67D43D2D; Tue, 14 Dec 2004 11:26:05 +0000 (GMT)
	(envelope-from vs@FreeBSD.org)
Received: from freefall.freebsd.org (vs@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.1/8.13.1) with ESMTP id iBEBQ5ZI091250;
	Tue, 14 Dec 2004 11:26:05 GMT
	(envelope-from vs@freefall.freebsd.org)
Received: (from vs@localhost)
	by freefall.freebsd.org (8.13.1/8.13.1/Submit) id iBEBQ5gv091246;
	Tue, 14 Dec 2004 11:26:05 GMT
	(envelope-from vs)
Date: Tue, 14 Dec 2004 11:26:05 GMT
From: Volker Stolz <vs@FreeBSD.org>
Message-Id: <200412141126.iBEBQ5gv091246@freefall.freebsd.org>
To: cartola@openit.com.br, vs@FreeBSD.org,
	freebsd-ports-bugs@FreeBSD.org
Subject: Re: ports/71846: New port: graphics/libpano12 - program to mount
	panorama pictures - also a dependency to hugin
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>,
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>,
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Dec 2004 11:26:05 -0000

Synopsis: New port: graphics/libpano12 - program to mount panorama pictures - also a dependency to hugin

State-Changed-From-To: open->feedback
State-Changed-By: vs
State-Changed-When: Tue Dec 14 10:51:32 GMT 2004
State-Changed-Why: 
- Please use portlint, it will tell you that you must use tabs,
    not spaces
- Please use MASTER_SITES=${MASTER_SITE_SOURCEFORGE} /
             MASTER_SITE_SUBDIR=panotools
- USE_BZIP=yes since that distfile is smaller
- LDCONFIG_DIRS already contains the right value!
- You could use %%DOCSDIR%% in pkg-plist
- Why don't you use the included "configure"?
- Hardcoded CC/CFLAGS in your custom makefile
- -fPIC doesn't look right
- trivial upgrade to recent version 2.7.0.8
- Please use bsd.java.mk v2.0, i.e.
   USE_JAVA=yes
   JAVA_VERSION=1.3+
- Missing file/dependency? PTDialogs.c:35:21: sys_x11.h: No such file or directory
    Looks like a typo for sys_X11. Why do you only want to build
    the ANSI-version anyway?

Please review my modifications at
http://www.foldr.org/~stolz/FreeBSD/libpano12.Makefile

You might want to surgically replace parts of Makefile.* with 'patch' to
limit what will actually be built instead of your hand-crafted Makefile.
Better yet: find out why it's falling over at all -- is there a way to
disable X11 instead of setting -D__ANSI__?

Cheers,
  Volker

http://www.freebsd.org/cgi/query-pr.cgi?pr=71846