From owner-freebsd-ia64 Thu Feb 13 17: 2:48 2003 Delivered-To: freebsd-ia64@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 96B1237B401 for ; Thu, 13 Feb 2003 17:02:46 -0800 (PST) Received: from ns1.xcllnt.net (209-128-86-226.bayarea.net [209.128.86.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0987743F93 for ; Thu, 13 Feb 2003 17:02:45 -0800 (PST) (envelope-from marcel@xcllnt.net) Received: from athlon.pn.xcllnt.net (athlon.pn.xcllnt.net [192.168.4.3]) by ns1.xcllnt.net (8.12.6/8.12.6) with ESMTP id h1E12i1o030788; Thu, 13 Feb 2003 17:02:44 -0800 (PST) (envelope-from marcel@piii.pn.xcllnt.net) Received: from athlon.pn.xcllnt.net (localhost [127.0.0.1]) by athlon.pn.xcllnt.net (8.12.7/8.12.7) with ESMTP id h1E12iKQ001392; Thu, 13 Feb 2003 17:02:44 -0800 (PST) (envelope-from marcel@athlon.pn.xcllnt.net) Received: (from marcel@localhost) by athlon.pn.xcllnt.net (8.12.7/8.12.7/Submit) id h1E12ioF001391; Thu, 13 Feb 2003 17:02:44 -0800 (PST) Date: Thu, 13 Feb 2003 17:02:44 -0800 From: Marcel Moolenaar To: Arun Sharma Cc: freebsd-ia64@FreeBSD.ORG Subject: Re: Maxmem should be bytes ? Message-ID: <20030214010244.GA1344@athlon.pn.xcllnt.net> References: <200302080111.h181Bkr26574@unix-os.sc.intel.com> <20030214002346.GA1267@athlon.pn.xcllnt.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.3i Sender: owner-freebsd-ia64@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On Thu, Feb 13, 2003 at 04:47:04PM -0800, Arun Sharma wrote: > Marcel Moolenaar writes: > > On Thu, Feb 13, 2003 at 04:18:20PM -0800, Arun Sharma wrote: > > > Arun Sharma writes: > > > > > > > I found that my VHPT size was limited to 2**15 no matter how much > > > > memory I had. I tracked this down to the code in machdep.c:598. > > > > > > > > physmem is in units of pages and Maxmem is the number of bytes. This > > > > incorrect assignment results in a small VHPT size. > > > > > > I didn't see a response to this message. While VHPT < 2**15 isn't a > > > huge issue, this bug could result in other correctness problems. > > > > Such as? > > New code that tries to use ia64_ptob(Maxmem) for something other than > VHPT sizing would be broken. Like machdep.c:164? printf("real memory = %ld (%ld MB)\n", ia64_ptob(Maxmem), ia64_ptob(Maxmem) / 1048576); As for the fact that Maxmem is in bytes and physmem isn't: we define Maxmem to be equal to physmem (machdep.c:598). So they are in fact equal. > And of course, it doesn't hurt to have a > bigger VHPT on large memory machines :) Agreed. However, I'd like us to first get things to work without VHPT (especially SMP) and then focus on getting a good VHPT implementation. I think this way we'll have the best infrastructure. I have it planned after EPC (I'm working on that right now). -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ia64" in the body of the message