From owner-freebsd-bugs Wed Oct 2 20:30: 5 2002 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7B54F37B401 for ; Wed, 2 Oct 2002 20:30:02 -0700 (PDT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 68FEF43E6E for ; Wed, 2 Oct 2002 20:30:01 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.6/8.12.6) with ESMTP id g933U1Co096135 for ; Wed, 2 Oct 2002 20:30:01 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.6/8.12.6/Submit) id g933U13T096134; Wed, 2 Oct 2002 20:30:01 -0700 (PDT) Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2B94937B401; Wed, 2 Oct 2002 20:21:50 -0700 (PDT) Received: from tomts16-srv.bellnexxia.net (tomts16.bellnexxia.net [209.226.175.4]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6D60843E42; Wed, 2 Oct 2002 20:21:49 -0700 (PDT) (envelope-from matt@gsicomp.on.ca) Received: from xena.gsicomp.on.ca ([65.95.176.54]) by tomts16-srv.bellnexxia.net (InterMail vM.5.01.04.19 201-253-122-122-119-20020516) with ESMTP id <20021003032148.SSJ15333.tomts16-srv.bellnexxia.net@xena.gsicomp.on.ca>; Wed, 2 Oct 2002 23:21:48 -0400 Received: from dhcp2.gsicomp.on.ca (dhcp2.gsicomp.on.ca [192.168.0.11]) by xena.gsicomp.on.ca (8.11.3/8.11.3) with ESMTP id g9321mp12207; Wed, 2 Oct 2002 22:01:48 -0400 (EDT) (envelope-from matt@dhcp2.gsicomp.on.ca) Received: (from matt@localhost) by dhcp2.gsicomp.on.ca (8.12.6/8.12.6/Submit) id g933LiF7023407; Wed, 2 Oct 2002 23:21:44 -0400 (EDT) (envelope-from matt) Message-Id: <200210030321.g933LiF7023407@dhcp2.gsicomp.on.ca> Date: Wed, 2 Oct 2002 23:21:44 -0400 (EDT) From: Matt Emmerton Reply-To: Matt Emmerton To: FreeBSD-gnats-submit@FreeBSD.org, itojun@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: kern/43611: static-ize some symbols in sys/crypto Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org >Number: 43611 >Category: kern >Synopsis: static-ize some symbols in sys/crypto >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Wed Oct 02 20:30:00 PDT 2002 >Closed-Date: >Last-Modified: >Originator: Matt Emmerton >Release: FreeBSD 5.0-CURRENT i386 >Organization: GSI Computer Services >Environment: System: FreeBSD laptop.gsicomp.on.ca 5.0-CURRENT FreeBSD 5.0-CURRENT #5: Mon Sep 23 21:24:44 EDT 2002 root@laptop.gsicomp.on.ca:/usr/obj/usr/src/sys/LAPTOP.20020914.01 i386 >Description: PKH's JKH TODO List - kernel orphan symbol review This patch makes some symbols in sys/crypto static, as they are not used outside the scope of this code and do not need to be visible. >How-To-Repeat: >Fix: --- sys/crypto/rijndael/boxes-fst.dat.orig Wed Oct 2 23:15:21 2002 +++ sys/crypto/rijndael/boxes-fst.dat Wed Oct 2 23:15:41 2002 @@ -1,7 +1,7 @@ /* $FreeBSD: src/sys/crypto/rijndael/boxes-fst.dat,v 1.2 2001/06/11 12:38:55 ume Exp $ */ /* $KAME: boxes-fst.dat,v 1.6 2001/05/27 00:23:22 itojun Exp $ */ -const word8 S[256] = { +static const word8 S[256] = { 99, 124, 119, 123, 242, 107, 111, 197, 48, 1, 103, 43, 254, 215, 171, 118, 202, 130, 201, 125, 250, 89, 71, 240, 173, 212, 162, 175, 156, 164, 114, 192, 183, 253, 147, 38, 54, 63, 247, 204, 52, 165, 229, 241, 113, 216, 49, 21, --- sys/crypto/sha2/sha2.c.orig Wed Oct 2 23:14:53 2002 +++ sys/crypto/sha2/sha2.c Wed Oct 2 23:15:01 2002 @@ -202,9 +202,9 @@ * library -- they are intended for private internal visibility/use * only. */ -void SHA512_Last(SHA512_CTX*); -void SHA256_Transform(SHA256_CTX*, const sha2_word32*); -void SHA512_Transform(SHA512_CTX*, const sha2_word64*); +static void SHA512_Last(SHA512_CTX*); +static void SHA256_Transform(SHA256_CTX*, const sha2_word32*); +static void SHA512_Transform(SHA512_CTX*, const sha2_word64*); /*** SHA-XYZ INITIAL HASH VALUES AND CONSTANTS ************************/ >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message