From owner-freebsd-bugs  Sat Oct 27  9:11:38 2001
Delivered-To: freebsd-bugs@freebsd.org
Received: from relay1.macomnet.ru (relay1.macomnet.ru [195.128.64.10])
	by hub.freebsd.org (Postfix) with ESMTP id 7F6AF37B401
	for <freebsd-bugs@FreeBSD.ORG>; Sat, 27 Oct 2001 09:11:34 -0700 (PDT)
Received: from news1.macomnet.ru (news1.macomnet.ru [195.128.64.14])
	by relay1.macomnet.ru (8.11.3/8.11.3) with ESMTP id f9RGBQo1322567;
	Sat, 27 Oct 2001 20:11:26 +0400 (MSD)
Date: Sat, 27 Oct 2001 20:11:25 +0400 (MSD)
From: Maxim Konovalov <maxim@macomnet.ru>
To: Bob Bishop <rb@gid.co.uk>
Cc: freebsd-bugs@FreeBSD.ORG
Subject: Re: bin/31533: /bin/sh memory leak
In-Reply-To: <200110271550.f9RFo1M56158@freefall.freebsd.org>
Message-ID: <20011027200858.V91369-100000@news1.macomnet.ru>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-bugs.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-bugs>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-bugs>
X-Loop: FreeBSD.org

On Sat, 27 Oct 2001, Bob Bishop wrote:

> The following reply was made to PR bin/31533; it has been noted by GNATS.
>
> From: Bob Bishop <rb@gid.co.uk>
> To: freebsd-gnats-submit@FreeBSD.org, rb@gid.co.uk
> Cc:
> Subject: Re: bin/31533: /bin/sh memory leak
> Date: Sat, 27 Oct 2001 16:39:58 +0100
>
>  Also affects -CURRENT

How about this patch:

Index: cd.c
===================================================================
RCS file: /home/ncvs/src/bin/sh/cd.c,v
retrieving revision 1.20
diff -u -r1.20 cd.c
--- cd.c	29 Nov 1999 19:10:58 -0000	1.20
+++ cd.c	27 Oct 2001 16:07:20 -0000
@@ -238,8 +238,8 @@
 		curdir = NULL;
 		if (getpwd() == NULL)
 			error("getcwd() failed: %s", strerror(errno));
-		setvar("PWD", curdir, VEXPORT | VTEXTFIXED);
-		setvar("OLDPWD", prevdir, VEXPORT | VTEXTFIXED);
+		setvar("PWD", curdir, VEXPORT);
+		setvar("OLDPWD", prevdir, VEXPORT);
 		INTON;
 		return;
 	}
@@ -270,8 +270,8 @@
 		ckfree(prevdir);
 	prevdir = curdir;
 	curdir = savestr(stackblock());
-	setvar("PWD", curdir, VEXPORT | VTEXTFIXED);
-	setvar("OLDPWD", prevdir, VEXPORT | VTEXTFIXED);
+	setvar("PWD", curdir, VEXPORT);
+	setvar("OLDPWD", prevdir, VEXPORT);
 	INTON;
 }

-- 
Maxim Konovalov, MAcomnet, Internet-Intranet Dept., system engineer
phone: +7 (095) 796-9079, mailto: maxim@macomnet.ru


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message