From owner-freebsd-testing@FreeBSD.ORG Fri Apr 4 23:28:21 2014 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D2BD27AA; Fri, 4 Apr 2014 23:28:21 +0000 (UTC) Received: from mail-pd0-x22b.google.com (mail-pd0-x22b.google.com [IPv6:2607:f8b0:400e:c02::22b]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9DF0CF5F; Fri, 4 Apr 2014 23:28:21 +0000 (UTC) Received: by mail-pd0-f171.google.com with SMTP id r10so3974202pdi.30 for ; Fri, 04 Apr 2014 16:28:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:mime-version:in-reply-to:content-type :content-transfer-encoding:message-id:cc:from:subject:date:to; bh=Qn2AhW5t3hpCbV9JUsBYxq7WyRwa3QEtwxeHGY8ApHI=; b=GZbtsrTcPTo5BsQ+f0g5RkUMjIZBPRT2kSna8A3LDn4YZGDlYcKzf/W7LtKH9gv5tA 2BSPT/9Ewt94mlMLn0M1ktlSmXKxf/+vKyPUffkHqdkEtdEPs59de8Z0Of2WTcxMheqJ 0cF7aESI/U2sJOFWadKZ5OGVK/Wh9GHyPQvWlB952M/nGeG5rf0oIqwkQ/LWXqWXXLB+ qDhCKsTwKo05/jiy5lUO5L3R7pEhYYGWW0olT6BHQl0dBNIalQ93ZrxeCfAq/jBMT0zo AwxtSs3KG+JUluGrIyOLVZ9L0fysL61nT7QHDmwhyygFfs0iG7Tm5s9R0zb04bR4+c2+ 4kNQ== X-Received: by 10.68.211.164 with SMTP id nd4mr17759805pbc.44.1396654101293; Fri, 04 Apr 2014 16:28:21 -0700 (PDT) Received: from [10.80.66.181] ([166.170.41.109]) by mx.google.com with ESMTPSA id ac5sm20270576pbc.37.2014.04.04.16.28.20 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 04 Apr 2014 16:28:20 -0700 (PDT) References: <16437CC5729B5345AF77F816513376E8129868F1@MX103CL02.corp.emc.com> <16437CC5729B5345AF77F816513376E820BAA20A@MX103CL02.corp.emc.com> <16437CC5729B5345AF77F816513376E820BACB49@MX103CL02.corp.emc.com> Mime-Version: 1.0 (1.0) In-Reply-To: <16437CC5729B5345AF77F816513376E820BACB49@MX103CL02.corp.emc.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Message-Id: <2194A8F0-810B-471A-AD9C-C95C469EAD99@gmail.com> X-Mailer: iPhone Mail (11D167) From: Garrett Cooper Subject: Re: Makefiles for skip-level directories? Date: Fri, 4 Apr 2014 16:28:16 -0700 To: "Peel, Casey" Cc: "freebsd-testing@freebsd.org" X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Apr 2014 23:28:21 -0000 > On Apr 4, 2014, at 15:28, "Peel, Casey" wrote: >=20 > Ok, I figured it out and wrote up the following document (that is publishe= d on our internal wiki). You may take whatever you want of this for the Free= BSD wiki if you find it useful. >=20 > Something rcattelan pointed out while doing the code review for my gpart c= hanges that I wanted to run past you: > is the include bsd.own.mk to pick up MK_TESTS? > yes > do you need to do that in the files that are not look at MK_TESTS?= > geom/tests/Makefile ? > I probably don't have to, but that's how the other Makefiles like t= hat are done in FreeBSD, eg: src/bin/tests/Makefile > bsd.own.mk is included by bsd.init.mk which is included by bsd.tes= t.mk=20 > so it seems redundant > maybe we should ask the upstream if is correct ... might be better= to leave it off vs perpetuating something that might not be right Yeah, bsd.own.mk is redundant, but it doesn't do any harm minus a hit on the= cache, and increase the file sizes a small amount. In the event that the Makefile snippet would be removed from the included ma= kefiles then stuff would break horribly. Plus it makes it clear that MK_TEST= S is obtained from bsd.own.mk. Just a thought :/... Thanks! -Garrett=