From owner-freebsd-current@FreeBSD.ORG Wed Jul 4 19:48:08 2007 Return-Path: X-Original-To: freebsd-current@FreeBSD.org Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 93F1C16A400; Wed, 4 Jul 2007 19:48:08 +0000 (UTC) (envelope-from scf@FreeBSD.org) Received: from mail.farley.org (farley.org [67.64.95.201]) by mx1.freebsd.org (Postfix) with ESMTP id 4DA7213C45E; Wed, 4 Jul 2007 19:48:08 +0000 (UTC) (envelope-from scf@FreeBSD.org) Received: from thor.farley.org (thor.farley.org [192.168.1.5]) by mail.farley.org (8.14.1/8.14.1) with ESMTP id l64JnHdM014349; Wed, 4 Jul 2007 14:49:17 -0500 (CDT) (envelope-from scf@FreeBSD.org) Date: Wed, 4 Jul 2007 14:47:50 -0500 (CDT) From: "Sean C. Farley" To: Andrey Chernov In-Reply-To: <20070704180000.GA34042@nagual.pp.ru> Message-ID: <20070704144159.X77978@thor.farley.org> References: <1183557221.1799.16.camel@genius.i.cz> <20070704143642.GA31254@nagual.pp.ru> <20070704150312.GB31683@nagual.pp.ru> <20070704101026.O77978@thor.farley.org> <20070704173905.T67251@fledge.watson.org> <20070704121316.A77978@thor.farley.org> <20070704180000.GA34042@nagual.pp.ru> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.2.1 X-Spam-Checker-Version: SpamAssassin 3.2.1 (2007-05-02) on mail.farley.org Cc: freebsd-current , Robert Watson , Michal Mertl Subject: Re: Environment handling broken in /bin/sh with changes to {get,set,put}env() X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Jul 2007 19:48:08 -0000 On Wed, 4 Jul 2007, Andrey Chernov wrote: > On Wed, Jul 04, 2007 at 12:53:25PM -0500, Sean C. Farley wrote: >> functions. I am not certain that sh would work even with OpenSolaris >> since it does similar things to environ under the covers. > > It surely not works properly on anything excepting BSD due to this > habbit. > >> I am also actively looking for other potential bugs from this type of >> misuse. /bin/sh did not show up for me since I did not have LANG (or >> any other locale variable sh cares about) set in my environment. > > Don't care about login and su, they use pam_getenvlist() which copies > via malloc. My only concern is with programs (i.e., su) that "clean" the environment after calling setenv(), putenv() or unsetenv(). I wrote a patch[1] (and test program) that checks for a change of the address that environ is pointing. If it detects a change, it scraps all that it knows about environ (frees everything) and starts with the new environ. Of course, the sh patch[2] is still needed. Sean 1. http://www.farley.org/freebsd/tmp/setenv/clearenv/ 2. http://www.farley.org/freebsd/tmp/setenv/sh.patch -- scf@FreeBSD.org