From owner-freebsd-current@FreeBSD.ORG Thu Jul 11 17:41:21 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 38A80788; Thu, 11 Jul 2013 17:41:21 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) by mx1.freebsd.org (Postfix) with ESMTP id 14B7A1C2A; Thu, 11 Jul 2013 17:41:21 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 6BDFEB982; Thu, 11 Jul 2013 13:41:20 -0400 (EDT) From: John Baldwin To: freebsd-current@freebsd.org, freebsd-sparc64@freebsd.org Subject: Re: [head tinderbox] failure on sparc64/sparc64 Date: Thu, 11 Jul 2013 09:56:11 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p25; KDE/4.5.5; amd64; ; ) References: <201307110418.r6B4I4k8072864@freebsd-current.sentex.ca> <20130711070541.GA21264@itx> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201307110956.11699.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Thu, 11 Jul 2013 13:41:20 -0400 (EDT) Cc: Adrian Chadd X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Jul 2013 17:41:21 -0000 On Thursday, July 11, 2013 3:07:33 am Adrian Chadd wrote: > On 11 July 2013 00:05, Navdeep Parhar wrote: > > On Wed, Jul 10, 2013 at 10:38:47PM -0700, Adrian Chadd wrote: > >> I don't get why this is dying. any ideas? > > > > Maybe because sparc64's ucontext.h is getting pulled in, and it has > > this: > > > > #define mc_flags mc_global[0] > > Ugh, we should fix this. When did this happen? annotate is your friend. It's over 10 years old: Working file: /home/jhb/work/freebsd/svn/head/sys/sparc64/include/ucontext.h ------------------------------------------------------------------------ r105733 | jake | 2002-10-22 14:03:15 -0400 (Tue, 22 Oct 2002) | 13 lines - Expand struct trapframe to 256 bytes, make all fields fixed width and the same size. Add some fields that previously overlapped with something else or were missing. - Make struct regs and struct mcontext (minus floating point) the same as struct trapframe so converting between them is easy (null). - Add space for saving floating point state to struct mcontext. This requires that it be 64 byte aligned. - Add assertions that none of these structures change size, as they are part of the ABI. - Remove some dead code in sendsig(). - Save and restore %gsr in struct trapframe. Remember to restore %fsr. - Add some comments to exception.S. ------------------------------------------------------------------------ -- John Baldwin