From nobody Tue Mar 28 06:53:24 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Pm0ks1LyKz42jqP; Tue, 28 Mar 2023 06:53:25 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Pm0ks0rXcz3nJJ; Tue, 28 Mar 2023 06:53:25 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1679986405; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iPWdXSvRcdc+okkNz22bTiIy7qFCu+M0kD+XLqPpXck=; b=oGZ+YhhLXV1mVSx5uSF3ZzbL4/wxAH+cA+h3h1xBVyUzjwzzmdvdA5YHqI9E91WlZVns+0 H7Myl5hRj69pwrwVW6IVUD3oZTeWYWIJCi5KEz6fmXldumYXkqo2VbLnLRquV27dAoUYIx YbjWMPty7OHCyuJFoqCDf2PoKdiOZv1C3Mj8fPL/6NcRZ4XI8bzRJXXhL0KakjgVF9AV3m vfR5p+iJFPjAErxSoQ2DErcBNrzcOcT7ECOfHqqdhmHG0leB/0q2lSMO8HRSWfFtG78aId Cgoh+/CWntjMOXJMXOrT+CU9D3Ze2MTx+rZa9OmMnlb2X7gY7oqcjyYnd4/lYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1679986405; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iPWdXSvRcdc+okkNz22bTiIy7qFCu+M0kD+XLqPpXck=; b=G8X/TW3T0IEsX9MQD6Gfq02I3XrrCLVpjXH/UtJc2ThlfULCf08rVV/A90JsPVaW0z2e+O 6FDUT1LRPXEtmwhqUZlmxiIA0FLNcJyKVEJ4UlIraasS/mO9Z8q/pT9xARbT5CNnFStWGC sCK3PCi0YBG4M1oFSMewZfFxLmBPx34TESKD/NanL1mghcs3CGt3V/GlCpcQgyqglyeu2F Z84BgWl+IuNjmhrp8cpfGryTuntMR6op5cja4mJ/7lKCg2soLh2m0FzbjI0azQe0YZbCoR uso3LN79cFrjUyrdq/QfRNqcr8TPRIaYps91M+IEgRfRgYLa3AC6AtoCtBHkdQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1679986405; a=rsa-sha256; cv=none; b=j8x1+79sKSlkRl/9UkQciGHFfq2ODRBubKPqZvCxH03QSNcli0mt+CcFjywR+HNnf+A4+U 2qTJ+jPWXiYVscy51zPfks2yFSSk59ZH/KUDnlmjQNd6ZYHbkcnVJPOZf/PdwJ3AxDZuj8 n2IFhlhvk3Vl3vkQ4bMDUHQOZRY/JQ20QlYaO54+JWicYnEYzOxJP0wjJqHmqYXYbnsDO2 xxcZ96KTh+6jl6cVGOpJgdReIonoLKYe2Q+7jOq1zx5zto+f3L4ERjurnhwJsATUImSKMe xYCRzCQePZxVwc12jQ6g0FjN6BsCMjoheb2yOMQCIb3bE1m1/cSbgaBDE/SZNQ== Received: by freefall.freebsd.org (Postfix, from userid 1033) id 02AA21FCD4; Tue, 28 Mar 2023 06:53:24 +0000 (UTC) Date: Tue, 28 Mar 2023 06:53:24 +0000 From: Alexey Dokuchaev To: Jessica Clarke Cc: Alan Somers , Konstantin Belousov , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 61194e9852e6 - main - Add kqueue1() syscall Message-ID: References: <202303272339.32RNdWPD063667@gitrepo.freebsd.org> <930C69C9-64E3-4399-BE35-ABB137F06EC2@freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <930C69C9-64E3-4399-BE35-ABB137F06EC2@freebsd.org> X-ThisMailContainsUnwantedMimeParts: N On Tue, Mar 28, 2023 at 01:07:41AM +0100, Jessica Clarke wrote: > On 28 Mar 2023, at 00:45, Alan Somers wrote: > > On Mon, Mar 27, 2023 at 4:39???PM Konstantin Belousov wrote: > >> commit 61194e9852e641d1533cd04a5679d6042ff975d3 > >> > >> Add kqueue1() syscall > >> > >> It takes the flags argument. Immediate use is to provide the > >> KQUEUE_CLOEXEC flag for kqueue(2). > >> > >> Differential revision: https://reviews.freebsd.org/D39271 > > > > We already have abort2(2), dup2(2), pipe2(2), and thr_kill2(2) that > > are similar to other syscalls but with a flags argument. > > Additionally, Linux has a renameat(2). But I'm not aware of any > > syscalls named xxx1. Should we call this new one kqueue2 to follow > > the existing convention? > > This was discussed on the linked review. I'm with Alan here, all needed knownledge (results of discussions) should be part of the commit log, making commit itself sufficiently understandable and judgeable. ./danfe