Date: Tue, 28 Mar 2023 06:53:24 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Jessica Clarke <jrtc27@freebsd.org> Cc: Alan Somers <asomers@freebsd.org>, Konstantin Belousov <kib@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 61194e9852e6 - main - Add kqueue1() syscall Message-ID: <ZCKO5MG0Oe8rpYm6@FreeBSD.org> In-Reply-To: <930C69C9-64E3-4399-BE35-ABB137F06EC2@freebsd.org> References: <202303272339.32RNdWPD063667@gitrepo.freebsd.org> <CAOtMX2gmaZH4ywa=OdPH6yPJBXQdPQiNEfb-yMVizxDp_O8atA@mail.gmail.com> <930C69C9-64E3-4399-BE35-ABB137F06EC2@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Mar 28, 2023 at 01:07:41AM +0100, Jessica Clarke wrote: > On 28 Mar 2023, at 00:45, Alan Somers wrote: > > On Mon, Mar 27, 2023 at 4:39???PM Konstantin Belousov wrote: > >> commit 61194e9852e641d1533cd04a5679d6042ff975d3 > >> > >> Add kqueue1() syscall > >> > >> It takes the flags argument. Immediate use is to provide the > >> KQUEUE_CLOEXEC flag for kqueue(2). > >> > >> Differential revision: https://reviews.freebsd.org/D39271 > > > > We already have abort2(2), dup2(2), pipe2(2), and thr_kill2(2) that > > are similar to other syscalls but with a flags argument. > > Additionally, Linux has a renameat(2). But I'm not aware of any > > syscalls named xxx1. Should we call this new one kqueue2 to follow > > the existing convention? > > This was discussed on the linked review. I'm with Alan here, all needed knownledge (results of discussions) should be part of the commit log, making commit itself sufficiently understandable and judgeable. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ZCKO5MG0Oe8rpYm6>