From owner-freebsd-arm@FreeBSD.ORG Mon Mar 3 15:20:00 2014 Return-Path: Delivered-To: freebsd-arm@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D1BA164E for ; Mon, 3 Mar 2014 15:20:00 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 943B9328 for ; Mon, 3 Mar 2014 15:20:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.8/8.14.8) with ESMTP id s23FK06O088942 for ; Mon, 3 Mar 2014 15:20:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.8/8.14.8/Submit) id s23FK0gV088941; Mon, 3 Mar 2014 15:20:00 GMT (envelope-from gnats) Resent-Date: Mon, 3 Mar 2014 15:20:00 GMT Resent-Message-Id: <201403031520.s23FK0gV088941@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-arm@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Svatopluk Kraus Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 3659151F for ; Mon, 3 Mar 2014 15:14:51 +0000 (UTC) Received: from cgiserv.freebsd.org (cgiserv.freebsd.org [IPv6:2001:1900:2254:206a::50:4]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 227C72FF for ; Mon, 3 Mar 2014 15:14:51 +0000 (UTC) Received: from cgiserv.freebsd.org ([127.0.1.6]) by cgiserv.freebsd.org (8.14.8/8.14.8) with ESMTP id s23FEoNe083769 for ; Mon, 3 Mar 2014 15:14:50 GMT (envelope-from nobody@cgiserv.freebsd.org) Received: (from nobody@localhost) by cgiserv.freebsd.org (8.14.8/8.14.8/Submit) id s23FEoUS083764; Mon, 3 Mar 2014 15:14:50 GMT (envelope-from nobody) Message-Id: <201403031514.s23FEoUS083764@cgiserv.freebsd.org> Date: Mon, 3 Mar 2014 15:14:50 GMT From: Svatopluk Kraus To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: arm/187223: omap4 clock frequency computation overflow X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "Porting FreeBSD to ARM processors." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Mar 2014 15:20:00 -0000 >Number: 187223 >Category: arm >Synopsis: omap4 clock frequency computation overflow >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-arm >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Mar 03 15:20:00 UTC 2014 >Closed-Date: >Last-Modified: >Originator: Svatopluk Kraus >Release: FreeBSD 11.0-CURRENT >Organization: >Environment: Pandaboard ES >Description: uint32_t is not enough. See patch. >How-To-Repeat: >Fix: Patch attached with submission follows: Index: sys/arm/ti/omap4/omap4_prcm_clks.c =================================================================== --- sys/arm/ti/omap4/omap4_prcm_clks.c (revision 262153) +++ sys/arm/ti/omap4/omap4_prcm_clks.c (working copy) @@ -984,13 +984,11 @@ pll_mult = ((clksel >> 8) & 0x7ff); pll_div = (clksel & 0x7f) + 1; - /* Get the system clock freq */ omap4_clk_get_sysclk_freq(NULL, &sysclk); - /* Calculate the MPU freq */ - mpuclk = (sysclk * pll_mult) / pll_div; + mpuclk = ((uint64_t)sysclk * pll_mult) / pll_div; /* Return the value */ if (freq) >Release-Note: >Audit-Trail: >Unformatted: