From owner-freebsd-current@FreeBSD.ORG  Sun Oct 19 10:33:12 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id CA70B16A4B3
	for <current@FreeBSD.ORG>; Sun, 19 Oct 2003 10:33:12 -0700 (PDT)
Received: from spider.deepcore.dk
	(cpe.atm2-0-56339.0x50c6aa0a.abnxx2.customer.tele.dk [80.198.170.10])
	by mx1.FreeBSD.org (Postfix) with ESMTP id E3DDE43FBD
	for <current@FreeBSD.ORG>; Sun, 19 Oct 2003 10:33:10 -0700 (PDT)
	(envelope-from sos@spider.deepcore.dk)
Received: from spider.deepcore.dk (localhost [127.0.0.1])
	by spider.deepcore.dk (8.12.10/8.12.10) with ESMTP id h9JHWDlG063602;
	Sun, 19 Oct 2003 19:32:13 +0200 (CEST)
	(envelope-from sos@spider.deepcore.dk)
Received: (from sos@localhost)
	by spider.deepcore.dk (8.12.10/8.12.10/Submit) id h9JHWCfm063601;
	Sun, 19 Oct 2003 19:32:12 +0200 (CEST)
	(envelope-from sos)
From: Soren Schmidt <sos@spider.deepcore.dk>
Message-Id: <200310191732.h9JHWCfm063601@spider.deepcore.dk>
In-Reply-To: <20031016231747.4f0640e3.eyes@navi.org>
To: Hiroyuki Aizu <eyes@navi.org>
Date: Sun, 19 Oct 2003 19:32:12 +0200 (CEST)
X-Mailer: ELM [version 2.4ME+ PL99f (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset=ISO-8859-1
X-mail-scanned: by DeepCore Virus & Spam killer v1.3
cc: current@FreeBSD.ORG
Subject: Re: PATCH for ATAng
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 19 Oct 2003 17:33:12 -0000

It seems Hiroyuki Aizu wrote:
> Hi.
> 
> The original ata_reset() lost ATA-master drive and remove main file system
> after suspend/resume. Of cource it occors panic!
> I think that the ata_reset() in ata-lowlevel.c is bogus and I can not
> understand the code. So I study ATA and rewrite ata_reset() completely.
> 
> New device detect algorism using ata command ATA_IDENTIFY_DEVICE and
> ATA_IDENTIFY_PACKET_DEVICE for judge ATA and ATAPI devices.
> 
> This patch works fine with my TOSHIBA Libretto L5. 
> But not yet test ATAPI devices and ATA-slave channel.
> Maybe there is need to adjust wait DELAY time.
> 
> Please test and replace ata_reset().

Hold your horses just a bit please, I suggest that you try to understand
the current code first, then we can talk about improving it..

> I hope this solve ATAng troubles.

It will probably solve some troubles but I'll bet it will produce quite
a few new ones :)

Anyhow I'll look at your code asap, but from a quick look it shows that
you havn't looked seriously at the existing code, and that is not a
good sign in my book sorry...

-Søren