From owner-svn-src-head@FreeBSD.ORG  Thu Sep 27 13:18:10 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
	id 7EFBA106566B; Thu, 27 Sep 2012 13:18:10 +0000 (UTC)
Date: Thu, 27 Sep 2012 13:18:10 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Edward Tomasz Napierala <trasz@FreeBSD.org>
Message-ID: <20120927131810.GA54552@FreeBSD.org>
References: <201209271051.q8RApcmq002950@svn.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <201209271051.q8RApcmq002950@svn.freebsd.org>
User-Agent: Mutt/1.4.2.1i
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r240993 - head/sys/cam/ctl
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Sep 2012 13:18:10 -0000

On Thu, Sep 27, 2012 at 10:51:38AM +0000, Edward Tomasz Napierala wrote:
> New Revision: 240993
> URL: http://svn.freebsd.org/changeset/base/240993
> 
> Log:
>   Remove useless NULL checks after M_WAITOK allocations.
> 
> @@ -1520,12 +1520,6 @@ ctl_ioctl_do_datamove(struct ctl_scsiio 
>  
>  	ext_sglist = (struct ctl_sg_entry *)malloc(ext_sglen, M_CTL, M_WAITOK);

You could have also removed bogus casting of void * returned by malloc().
Perhaps it makes sense to clean up more than just this file thought.

./danfe