From owner-svn-src-head@FreeBSD.ORG Tue Nov 18 22:22:32 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 3A928B25; Tue, 18 Nov 2014 22:22:32 +0000 (UTC) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 119A7C97; Tue, 18 Nov 2014 22:22:32 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id EEB84B9C4; Tue, 18 Nov 2014 17:22:30 -0500 (EST) From: John Baldwin To: Adrian Chadd Subject: Re: svn commit: r274635 - head/sys/dev/pci Date: Tue, 18 Nov 2014 17:20:01 -0500 User-Agent: KMail/1.13.5 (FreeBSD/8.4-CBSD-20140415; KDE/4.5.5; amd64; ; ) References: <201411172025.sAHKPLMl055666@svn.freebsd.org> <2245618.H2SPKlpWdS@ralph.baldwin.cx> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201411181720.01235.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Tue, 18 Nov 2014 17:22:31 -0500 (EST) Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" , Dmitry Chagin X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Nov 2014 22:22:32 -0000 On Monday, November 17, 2014 6:17:25 pm Adrian Chadd wrote: > On 17 November 2014 14:45, John Baldwin wrote: > > On Monday, November 17, 2014 08:25:21 PM Dmitry Chagin wrote: > >> Author: dchagin > >> Date: Mon Nov 17 20:25:21 2014 > >> New Revision: 274635 > >> URL: https://svnweb.freebsd.org/changeset/base/274635 > >> > >> Log: > >> Use the correct device as the power_for_sleep() method > >> always pass request up to parent bridge. > >> > >> Reviewed by: jhb > >> MFC after: 1 week > >> xMFC: r274386,r274397 > > > > Hmm, I had misread this diff as being another instance of what Adrian had > > found. I think this is actually not correct. The parent of a pci device > > ('dev' here) is a pciX device. pciX devices do not implement the > > PCIB_POWER_FOR_SLEEP method from pcib_if.m, so this probably just broke > > Adrian's Asus laptop as now it will always use D3 again and ignore _SxD. > > > > You said that this change fixed your laptop, yes? Did it work before Adrian's > > change in r274386 and break afterwards? > > Hm, it doesn't cascade up to the parent of dev if it's called? No, not all kobj methods do this. In this case this is a pcib_if method, so it is an interface supported by PCI bridge devices only. PCI bus devices aren't bridges, so they don't implement it. Similarly, pcib devices don't implement pci_if.m methods either. -- John Baldwin