From owner-freebsd-net@freebsd.org Tue Mar 23 02:46:03 2021 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BE52F57400F for ; Tue, 23 Mar 2021 02:46:03 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-ot1-f53.google.com (mail-ot1-f53.google.com [209.85.210.53]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4F4G2g4yBDz3QMb; Tue, 23 Mar 2021 02:46:03 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-ot1-f53.google.com with SMTP id s11-20020a056830124bb029021bb3524ebeso1329334otp.0; Mon, 22 Mar 2021 19:46:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/9spfX+3iJzJE/frSH3QuyQRjUDx7kehKSkI+r8MrFY=; b=e1amZvJ2WNurTfkBgDmfPbYlo3UT1z8LEqeS87Aq5vK84twSc9fGuE7wkCArRvqinC i0gfr01RUXIw1f2tZYJ+wR9zQaVa0asdc/pDUqtUhlsZiPKxdq+PpIqIU1+fhVH8fKfL qk5ioxMyvWfz9aMFgdhSnjBCII7pma7VQxuTTFMKYcOD46ieO4WoSnzrsat0kj0+iQC3 1cTcsZe1WkKs3SsVTc2ndiCh9WDxckvLATvYZSXpJXXBEZG4W00KY4U/RnI91bCeGAMl pX7HscBZIpgcOscp8wcGD3MFNZew1qNc8TWh6EkSMRkEvv1uhCM9V1p4cdGF2K3YUzKb wYsw== X-Gm-Message-State: AOAM530o22TEK197X1szV04GmZubl7FdRboEaV5c/d5DgQN8IV0U+AsQ F+604v5yLc4B7idZs6iZxHmEqdCkFJJKGSa83Fk= X-Google-Smtp-Source: ABdhPJyn4G790KG7A5B7Brt5i3DrszAd9TYf8wK6tBISjzTcgZ4EBd1VeRGYJWG3HIKrx007PaXhUnoPI3/DByJGnPo= X-Received: by 2002:a05:6830:1af6:: with SMTP id c22mr2331749otd.291.1616467562371; Mon, 22 Mar 2021 19:46:02 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Alan Somers Date: Mon, 22 Mar 2021 20:45:51 -0600 Message-ID: Subject: Re: tcp-testsuite into src? To: Kevin Bowling Cc: FreeBSD Net , Michael Tuexen , rscheff@freebsd.org X-Rspamd-Queue-Id: 4F4G2g4yBDz3QMb X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Mar 2021 02:46:03 -0000 On Mon, Mar 22, 2021 at 7:31 PM Kevin Bowling wrote: > Hi, > > I was talking with gnn and kevans on IRC about the tcp testsuite > (https://github.com/freebsd-net/tcp-testsuite). > > Currently we maintain this in ports, although the way the port is set > up doesn't make a lot of sense because the tests are stack specific > and we don't account for different FreeBSD versions let alone vendor > trees. It seems reasonable to me to pull the tests themselves (i.e. > https://github.com/freebsd-net/tcp-testsuite) into src where they can > follow along with the tree they are running on, and provide vendors a > natural point of extension. > > /usr/tests has some existing examples of relying on out of tree > binaries to run so I am not convinced we need to import packetdrill > itself but I don't have a strong preference. tuexen, do you have any > preference? > > Regards, > Kevin > _______________________________________________ > freebsd-net@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" > Yeah, it's not a problem to use binaries from ports in /usr/tests. As long as the tests can compile they can live in the base system. Is there a strong incentive to import them? Do they need to be adjusted for each release?