From nobody Sat May 7 21:06:02 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 801761ABA1FE for ; Sat, 7 May 2022 21:06:22 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ua1-x92e.google.com (mail-ua1-x92e.google.com [IPv6:2607:f8b0:4864:20::92e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Kwg313JStz3R2S for ; Sat, 7 May 2022 21:06:21 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-ua1-x92e.google.com with SMTP id x21so4017784uan.13 for ; Sat, 07 May 2022 14:06:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XnSI18GFr2b0GKP7xwnGNKnc6d6AdMZmzmLNjSa6MfM=; b=xUn3kThdaNrX2jHGlfB09AdScappH8dlJn0sczmPDMiW1WFMOC7pWy9hiaCIxvdr+W 8Yc8kWnmrX+gwaxLjBJLe/n0UrnQspNbSi4fGaIrf4L41eqNM2EXvDYX3GZWikiX9tZo FDLj14qrlPqcGka2Mu+CMcqfOgnDOj2BpAdIIDe8Pj0/F9rM8hrEQNzQlpwCUAnWpEHD PCDJkMl7t0xO28AG6AtX2DaygGiGGoJwkQ0Sq3U5z/2xjNBpZsVrPqjcQKhw+hnGpybV 6L02X8El21bOVQX6jUWR/JeFAf3S6aVJLurZe+RQS9ReMNchmhfwX9hu8hfaZ55l8Cac XDQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XnSI18GFr2b0GKP7xwnGNKnc6d6AdMZmzmLNjSa6MfM=; b=kRc6p2usbi8Ve1oeXFhbcj67Eq/fiwN4Sut0R4NzPGPziUPTomucxgbEU76epLvV5i vrVi9mGqG4JGEuOTE9UevOxf8KxqNyaWG5bgF3bSsKjBQKmZ+hcqyANHFW9gksFf7nwC vGeBQsh3R/HPgf6vyPytuOF6kzX4Fnq07cg0mTUYpB7YrcCQ2hMOcrLqx+eTigttuGpl /Rtc7bMlKzydXEkj2PocV+k8EKweV+FwSq+jjReYFRFsW9+hFtfk9JnJCN5hu1m9/DmR eAuSGtWLH1uu837U0pHbvw6EZJ4ORZdcTTcxnQq14wypsXt04z5RS2LutA5PB3xQaPNo TevA== X-Gm-Message-State: AOAM533xDyX1wXPl4ztaWQYrgocIzyalVLFrjFALOz3gMRKaPJQBd3gD HQggmkZkGNg93nV7HlBCVRf8NhudOe2U3jVRLe/hUQ== X-Google-Smtp-Source: ABdhPJwXihiTdMiultUfTrQUDLVuOESoGwi4kORoj7EXqc/2e3su6GRyoU37DBpHPmhA3ySo3xZUXUmOmH3bAoTizlU= X-Received: by 2002:ab0:6f8f:0:b0:35d:5045:46c4 with SMTP id f15-20020ab06f8f000000b0035d504546c4mr5046168uav.116.1651957574826; Sat, 07 May 2022 14:06:14 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202205071534.247FYcoV087948@gitrepo.freebsd.org> In-Reply-To: From: Warner Losh Date: Sat, 7 May 2022 15:06:02 -0600 Message-ID: Subject: Re: git: 2e32d4e41d20 - main - param.h: Bump FreeBSD_Version to 1400058 for devclass newbus changes To: John Baldwin Cc: Warner Losh , src-committers , "" , dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="0000000000006e8ea005de725854" X-Rspamd-Queue-Id: 4Kwg313JStz3R2S X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20210112.gappssmtp.com header.s=20210112 header.b=xUn3kThd; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::92e) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-2.12 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.95)[-0.946]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20210112.gappssmtp.com:s=20210112]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20210112.gappssmtp.com:+]; NEURAL_HAM_SHORT(-0.18)[-0.177]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::92e:from]; MLMMJ_DEST(0.00)[dev-commits-src-all]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; R_SPF_NA(0.00)[no SPF record]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-ThisMailContainsUnwantedMimeParts: N --0000000000006e8ea005de725854 Content-Type: text/plain; charset="UTF-8" On Sat, May 7, 2022, 2:17 PM John Baldwin wrote: > On 5/7/22 8:34 AM, Warner Losh wrote: > > The branch main has been updated by imp: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=2e32d4e41d205d6f14834f87306a77ff77b9c0bd > > > > commit 2e32d4e41d205d6f14834f87306a77ff77b9c0bd > > Author: Warner Losh > > AuthorDate: 2022-05-07 15:32:47 +0000 > > Commit: Warner Losh > > CommitDate: 2022-05-07 15:32:47 +0000 > > > > param.h: Bump FreeBSD_Version to 1400058 for devclass newbus changes > > > > jhb changed the newbus ABI and it's affecting some ports. Bump the > > version to give them something to key off of for the removal of the > > devclass arg from some macros. In theory the change should have been > > ABI neutral, but there some build breakage with drm-kmod so better > > to bump than not. > > > > Sponsored by: Netflix > > Mmmm, I'm guessing this is from some of the helpers for things like MMC > and i2c bridges rather than the core macros in sys/bus.h? For the > regular *DRIVER_MODULE* macros you should still be able to use the devclass > argument just fine on main still, and I won't remove that until after I > have MFC'd the API compat shims to 13.x. > > Ah, from Cy's followup I'm guessing it isn't actually the macros, but > the removal of iic_devclass or some such instead (and I haven't planned > on MFC'ing that), so this bump makes sense for those. > Should I update the docs then to be more explicit that its these other devclasses? Warner > -- > John Baldwin > --0000000000006e8ea005de725854 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Sat, May 7, 2022, 2:17 PM John Baldwin <jhb@freebsd.org> wrote:
On 5/7/22 8:34 AM, Warner Losh wrote:
> The branch main has been updated by imp:
>
> URL: https://cgit.FreeBSD.org/src/commit/?id=3D2e32d4e41d205d6f14834f87306a77= ff77b9c0bd
>
> commit 2e32d4e41d205d6f14834f87306a77ff77b9c0bd
> Author:=C2=A0 =C2=A0 =C2=A0Warner Losh <imp@FreeBSD.org>
> AuthorDate: 2022-05-07 15:32:47 +0000
> Commit:=C2=A0 =C2=A0 =C2=A0Warner Losh <imp@FreeBSD.org>
> CommitDate: 2022-05-07 15:32:47 +0000
>
>=C2=A0 =C2=A0 =C2=A0 param.h: Bump FreeBSD_Version to 1400058 for devcl= ass newbus changes
>=C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0 jhb changed the newbus ABI and it's affecting = some ports. Bump the
>=C2=A0 =C2=A0 =C2=A0 version to give them something to key off of for t= he removal of the
>=C2=A0 =C2=A0 =C2=A0 devclass arg from some macros. In theory the chang= e should have been
>=C2=A0 =C2=A0 =C2=A0 ABI neutral, but there some build breakage with dr= m-kmod so better
>=C2=A0 =C2=A0 =C2=A0 to bump than not.
>=C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0 Sponsored by:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0Netflix

Mmmm, I'm guessing this is from some of the helpers for things like MMC=
and i2c bridges rather than the core macros in sys/bus.h?=C2=A0 For the
regular *DRIVER_MODULE* macros you should still be able to use the devclass=
argument just fine on main still, and I won't remove that until after I=
have MFC'd the API compat shims to 13.x.

Ah, from Cy's followup I'm guessing it isn't actually the macro= s, but
the removal of iic_devclass or some such instead (and I haven't planned=
on MFC'ing that), so this bump makes sense for those.
<= /div>


Should I update the docs then to be more explicit that its these = other devclasses?

Warner= =C2=A0
--
John Baldwin
--0000000000006e8ea005de725854--