From owner-freebsd-audit  Tue May  1 22:15:35 2001
Delivered-To: freebsd-audit@freebsd.org
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by hub.freebsd.org (Postfix) with ESMTP id 0FC4E37B43C
	for <audit@FreeBSD.ORG>; Tue,  1 May 2001 22:15:33 -0700 (PDT)
	(envelope-from bde@zeta.org.au)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id PAA17986;
	Wed, 2 May 2001 15:15:09 +1000
Date: Wed, 2 May 2001 15:14:00 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-Sender: bde@besplex.bde.org
To: Will Andrews <will@physics.purdue.edu>
Cc: Dima Dorfman <dima@unixfreak.org>, audit@FreeBSD.ORG
Subject: Re: {get,set}progname functions
In-Reply-To: <20010501225758.Q5017@casimir.physics.purdue.edu>
Message-ID: <Pine.BSF.4.21.0105021510570.40807-100000@besplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-audit@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

On Tue, 1 May 2001, Will Andrews wrote:

> On Tue, May 01, 2001 at 07:53:21PM -0700, Dima Dorfman wrote:
> > Please review and, if acceptable, commit it.
> 
> style(9) says:
> 
>      Only use the __P macro from the include file <sys/cdefs.h> if the source
>      file in general is (to be) compilable with a K&R Old Testament compiler.
>      Use of the __P macro in new code is discouraged, although modifications
>      to existing files should be consistent with that file's conventions.

<stdlib.h> is to be compilable with a K&R Old Testament compiler, and
follows the convention of using __P(()) for all functions, so this
rule says (twice) that additions to <stdlib.h> must use __P(()).

> Nuke __P() while you're at it.

Nothing to nuke.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message