From owner-cvs-all Fri Dec 11 11:33:47 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id LAA16365 for cvs-all-outgoing; Fri, 11 Dec 1998 11:33:47 -0800 (PST) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from alpo.whistle.com (alpo.whistle.com [207.76.204.38]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id LAA16354; Fri, 11 Dec 1998 11:33:43 -0800 (PST) (envelope-from julian@whistle.com) Received: (from daemon@localhost) by alpo.whistle.com (8.8.5/8.8.5) id LAA05803; Fri, 11 Dec 1998 11:26:40 -0800 (PST) Received: from current1.whistle.com(207.76.205.22) via SMTP by alpo.whistle.com, id smtpdqP5799; Fri Dec 11 19:26:29 1998 Message-ID: <367171E2.62319AC4@whistle.com> Date: Fri, 11 Dec 1998 11:26:26 -0800 From: Julian Elischer Organization: Whistle Communications X-Mailer: Mozilla 3.0Gold (X11; I; FreeBSD 2.2.7-RELEASE i386) MIME-Version: 1.0 To: "Justin T. Gibbs" CC: Julian Elischer , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/dev/usb ohci.c References: <199812110608.XAA03707@pluto.plutotech.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk Justin T. Gibbs wrote: > > > This fixes the symptom and not the cause. > > The right answer is to let the PCI system know that the attach failed, > > or to fail earlier (in the PCI probe). > > The attach() is a void fn() so it can't return failure.. > > pci_unmap_int should also be implemented. > > -- > Justin Sure, who's working in that code? To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message