From nobody Mon Apr 13 18:45:39 2026 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fvbvZ3GwFz6ZY7f for ; Mon, 13 Apr 2026 18:45:46 +0000 (UTC) (envelope-from celeste.ornato1@gmail.com) Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fvbvY0ypqz3dfg for ; Mon, 13 Apr 2026 18:45:45 +0000 (UTC) (envelope-from celeste.ornato1@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20251104 header.b=hMnMaAHG; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of celeste.ornato1@gmail.com designates 2a00:1450:4864:20::336 as permitted sender) smtp.mailfrom=celeste.ornato1@gmail.com Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-488b0046078so47209625e9.1 for ; Mon, 13 Apr 2026 11:45:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776105943; x=1776710743; darn=freebsd.org; h=content-transfer-encoding:mime-version:message-id:date:user-agent :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6fkjvK2NTqOsdi702hov3g58mjX64KeErOD6MmYNhQw=; b=hMnMaAHGQIMlMGuQJZ9NuH8KUZFBmk1i8Yvcda3D6wVqInqYdz/QjUbmAlNQo5NR+m vDPSHvOWhAVieLoc3XF827NWotQgdxK0mfH0jcOIX/7L7Yr0hzaeB3tMuE1v3nMXb336 z+YeHXybssLiqr7bMbubhMhneqVvyTv9SycPCyleiLwGiWVVOcwXQPpI9WhtXymB0kY8 cdoFT/yWZa6LZS6qwR9R/zHUaXY/bYYJDDvhM2qfTsZz3jbXhhHdAcrvZya+ZvjdUvFB qQZzv2VZiyOIuwsUiMjAKzBLB3GYhD/IRxGO57aHEPeWOfUH7Nk72J9NpxUlAWKd/KW6 RIhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776105943; x=1776710743; h=content-transfer-encoding:mime-version:message-id:date:user-agent :references:in-reply-to:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6fkjvK2NTqOsdi702hov3g58mjX64KeErOD6MmYNhQw=; b=oxt/tEW1KEd0HmdmxCBadzEnuL9ZrLBFRPAmGDcuW52kbemU8Id7vEVQ+jfeUBm2QW epgGnVGNcFHeIADwTLnZtAfF/Z3Zg/q12mVcA1MROnxFWtqJYvrEzS0bbIE427viQ+uI LE/15ICF7l5QE3fpTftS0iikATRMnypFMZ2dVpkH2UZeJICXlquoAKPLIZ9lJm8SGJ1v KilAij7DiHMC7Ot9aUuYlfsc2VZOGl0e7KFXBNZnpHZQ9jBTT03OYPRasSZJb9rHWEXQ 9o8nW1RzfqBUjEgtnEiazXqudUkWRQgvN3XXvH6MZNamkBbm7aLhiVAZF2n0FPcvYOzb zfxg== X-Forwarded-Encrypted: i=1; AFNElJ8mLt1gsJ8dlu8IAoWM3msUpdaG2h3BXZW1F4AguvRo39Xae9t3yBwRV0PHHaXwhJfDG/aJ3YgmuRFnKHT+oku3p+8S+WL9@freebsd.org X-Gm-Message-State: AOJu0YzvJhefx0TSm+yLwVxJVafC2TwUGxyH9DWxLK59mtCoXTsdFkq3 uM6x1fuXQupfknmBrR3xjUcDrRaM1bCMIixFsNWOVRXFMJM5AkvpKAQw X-Gm-Gg: AeBDiesg4xPevu1cN6f+ZBI59PyJEQBv6lBd7t7W+HR80h8gg7LGXZiTGZfiB4RuqnS PEKFaeQJ2rdFxZd43QEOBHND4xuSwOKefHE0cBVAZljczcXtWkMDcKvK0MLgrYrz5rlY+wJnf5l lIwLDEplNh6AXH/fZy9mlSe6lb62LII4ikqqwY01tIu5kJaKvwlEhhoMFAYOtGDETl2hKcWYIw5 WEZe/LOWnFvQwFb+j1pjMmniJ0u0ikefRbfe7nroV8S3dXYjCk321qLMsho/OVnh777KBDS9kYa 0cn+Yoh9DKvbqUY4rZvgYTyFr82PBcS4MLxV0R0wHTj/j491ZDY/FgCprljX5fKJpfqdI/hLmvu 1s6e0oF2OSVHVf7J0H1gFZc9bkuVJVQcRZ1roY8BPZdomI0ghHSGMyOZ24Id5+yJYWZZQs9RBI2 K4cF77Irc/ylG8Jp+XSqgsVxhaZO2PeyvJS923iYBYud+fKRuxTR5BAyKHwbbYQ2aMdWECsYlun Dj0/T0WkvtxRVNOVh5jwF0+TzbrspIU0xhQCPis1fTqzUE0n0Ia35WPza0/jm+gSsyI7NaZ1NH6 nJ5cVbM0xew4GG30SvUt9OL9D56mLBcGD1BWtgE= X-Received: by 2002:a05:600c:c088:b0:488:a98b:b891 with SMTP id 5b1f17b1804b1-488d67bf75amr145663085e9.3.1776105942278; Mon, 13 Apr 2026 11:45:42 -0700 (PDT) Received: from freebased (net-93-71-194-94.cust.vodafonedsl.it. [93.71.194.94]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488e4d0ed99sm125688275e9.12.2026.04.13.11.45.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2026 11:45:41 -0700 (PDT) From: "=?utf-8?Q?C=C3=A9leste_Ornato?=" X-Google-Original-From: =?utf-8?Q?C=C3=A9leste_Ornato?= To: Daniel Engberg Cc: Kenneth Raplee , ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org, Celeste Ornato , Max Brazhnikov , Gleb Popov Subject: Re: git: 6fb8923e6ee4 - main - net-im/vesktop: New port In-Reply-To: <2bd5f43e-c5bd-4754-afad-7e11b8aa7b82@FreeBSD.org> (Daniel Engberg's message of "Mon, 13 Apr 2026 20:38:27 +0200") References: <69dccf3e.33ce7.3b6a1844@gitrepo.freebsd.org> <2bd5f43e-c5bd-4754-afad-7e11b8aa7b82@FreeBSD.org> User-Agent: mu4e 1.12.15; emacs 30.2 Date: Mon, 13 Apr 2026 20:45:39 +0200 Message-ID: <86wlya7l7w.fsf@gmail.com> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spamd-Result: default: False [-3.77 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.77)[-0.769]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20251104]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4864::/56:c]; MIME_GOOD(-0.10)[text/plain]; FROM_HAS_DN(0.00)[]; TAGGED_FROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; FREEMAIL_FROM(0.00)[gmail.com]; DKIM_TRACE(0.00)[gmail.com:+]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-ports-main@freebsd.org]; MID_RHS_MATCH_FROM(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-ports-main@freebsd.org]; RCPT_COUNT_SEVEN(0.00)[8]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::336:from] X-Rspamd-Queue-Id: 4fvbvY0ypqz3dfg X-Spamd-Bar: --- Hi, Duely noted, will not happen again. Your patch builds on my machine. Regards, C=C3=A9leste Daniel Engberg writes: > On 2026-04-13 13:10, Kenneth Raplee wrote: >> The branch main has been updated by kenrap: >> >> URL: https://cgit.FreeBSD.org/ports/commit/?id=3D6fb8923e6ee4571046330eb= f4b03a5f8a95c5c52 >> >> commit 6fb8923e6ee4571046330ebf4b03a5f8a95c5c52 >> Author: Celeste Ornato >> AuthorDate: 2026-04-02 00:24:26 +0000 >> Commit: Kenneth Raplee >> CommitDate: 2026-04-13 11:09:53 +0000 >> >> net-im/vesktop: New port >> Vesktop is a custom Discord App aiming to give you better perf= ormance >> and improved Unix-like support. >> PR: 294195 >> Co-authored-by: Kenneth Raplee >> Reviewed by: makc (mentor) >> Approved by: arrowd (co-mentor) >> --- >> net-im/vesktop/Makefile | 43 ++++++++++++++++++++++++++ >> net-im/vesktop/distinfo | 3 ++ >> net-im/vesktop/pkg-descr | 5 +++ >> net-im/vesktop/pkg-plist | 79 ++++++++++++++++++++++++++++++++++++++++= ++++++++ >> 4 files changed, 130 insertions(+) > Hi, > > A port should never extract directly into WRKDIR as this can cause variou= s issues including with the > framework itself. > https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-no_wrks= ubdir > > I also don't see any reviews or approvals in the PR or on Phab? > > You can also do a custom do-extract to avoid shuffling around 90Mbyte of = data. > > See PR 294489, https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D294489 > > Best regards, > Daniel