From owner-svn-src-head@freebsd.org Tue Nov 20 19:52:24 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 654B3113BFDF for ; Tue, 20 Nov 2018 19:52:24 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic316-20.consmr.mail.ne1.yahoo.com (sonic316-20.consmr.mail.ne1.yahoo.com [66.163.187.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A7B307FF00 for ; Tue, 20 Nov 2018 19:52:23 +0000 (UTC) (envelope-from marklmi@yahoo.com) X-YMail-OSG: LZaqsNgVM1kJr7oJ.nX12nLs0dXseWnI7nWXDNs8_fmCvjFuolTJWxj2WN2olfW adwZu_HUwSnHCvpRUMf7S8G.QPFoxP9xibZtGO1r9cJGGunkDk4NMADGfxOSlasQrG_nqO9e_SaZ eoJsjLRuGRN.ELJspCnSg7aJvJ.CA5NxhX_oo5H4xCqJUhQXHKQReKW_I5_K41PMiCuwhm6jW4L9 tg4tTi9hKwz2_vGhZIh76R7ZM7iB_21G27UHY6ntSQOosn.cTtNKKM5mvsnjdNatBrZ1fngicDaj NTmLet_OI.ijyeOwKhev.jgFrZmECpDLP420JENQ6Ll1sD095fQT5PRkhk5nwIwK0O_8qPn1SLo3 ZtGNXJtcMeoFHSyqzczzRot7dlfDI9H58bsW5PLiabazcDuxVOdUMEf_UUfU_EiPECuEk2AOQmk4 shAlB2C6_H6YCtUWL2.xPfuhq05IvA5LydRywDk4bHzSFByN5AjfmQ.Mzkw7iY6rbSj4y7kF80Pj 7eU9w.Y7EI9bvZqC5iYNQVFDI1pdCzNleGflAHN9ovS4rEHfNaUHWZL9oV9UR0iIYIi4YcpDUncg yYfBRQFB1Pg0ZWeox3FUqGZxMmgZQD6kOhYkf_stlxuP9EuBrSXsf2zfFeHI_WevEcZ2WHuG_.X. E849fSgjP8xNP2s99heftqy4vi02Q9YSIMR41EJXybCF56GtjkMuuLO689AQcDqeguj2maFXibTV ExPCM7G8rmkdef326QL10qsbwiCmOlWS0KB_Ps0YZeGs4Xxp2lCu7_pquzoLGjnXNsXb7oYum6Mg uigxe3xvlyQA2pk79znIQ7TBerySSinEE8ukHjMefEX2Mbq.KyHRPnhg7gx0h6mJEayHCcqzTwyw wrxSpGQ5BzdNelZ4a7ZBqmLkCpyqn0DWkkQ1a9Se5K9lD.GmB1vn4N8ASNiXkPfLssXowtT8yqmL 1.FF5CDIMGMQP6UcDKPwYbZNNXz8JQJA.LzadPKfFQyrgegR5jDGEfxz8IOc70JLd_92JIvGSmct Vx7ec3wwJEAuGgztF3RH0F6GQzJBTbO4UiVSXONCku29sES4dVIM6nA-- Received: from sonic.gate.mail.ne1.yahoo.com by sonic316.consmr.mail.ne1.yahoo.com with HTTP; Tue, 20 Nov 2018 19:52:16 +0000 Received: from c-76-115-7-162.hsd1.or.comcast.net (EHLO [192.168.1.25]) ([76.115.7.162]) by smtp425.mail.ne1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 0e5bd4161bc36d2cd63e4ce52d60dd22; Tue, 20 Nov 2018 19:52:08 +0000 (UTC) From: Mark Millard Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 12.1 \(3445.101.1\)) Subject: Re: svn commit: r340676 - in head/sys: kern sys Message-Id: Date: Tue, 20 Nov 2018 11:52:06 -0800 To: mjg@FreeBSD.org, svn-src-head@freebsd.org X-Mailer: Apple Mail (2.3445.101.1) X-Rspamd-Queue-Id: A7B307FF00 X-Spamd-Result: default: False [4.68 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; MV_CASE(0.50)[]; FREEMAIL_FROM(0.00)[yahoo.com]; TO_DN_NONE(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[yahoo.com:+]; MX_GOOD(-0.01)[cached: mta6.am0.yahoodns.net]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; FROM_EQ_ENVFROM(0.00)[]; IP_SCORE(1.66)[ip: (5.23), ipnet: 66.163.184.0/21(1.77), asn: 36646(1.41), country: US(-0.09)]; RCVD_TLS_LAST(0.00)[]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; ASN(0.00)[asn:36646, ipnet:66.163.184.0/21, country:US]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; FAKE_REPLY(1.00)[]; R_DKIM_ALLOW(-0.20)[yahoo.com]; FROM_HAS_DN(0.00)[]; NEURAL_SPAM_SHORT(0.91)[0.906,0]; MIME_GOOD(-0.10)[text/plain]; NEURAL_SPAM_MEDIUM(0.72)[0.719,0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_SPAM_LONG(0.91)[0.905,0]; RCVD_IN_DNSWL_NONE(0.00)[146.187.163.66.list.dnswl.org : 127.0.5.0] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Nov 2018 19:52:24 -0000 Mateusz Guzik mjg at FreeBSD.org wrote on Tue Nov 20 14:58:42 UTC 2018 : > +#if defined(__mips__) || defined(__powerpc__) > +#define UNR64_LOCKED > +#endif But on powerpc64 ( system clang from head -r339076 ): # clang -dM -E -x c /dev/null | grep -i __power #define __POWERPC__ 1 #define __powerpc64__ 1 #define __powerpc__ 1 and (I only have the one gcc* vintage around): # gcc8 -dM -E -x c /dev/null | grep -i __power #define __powerpc64__ 1 #define __powerpc__ 1 so the following are used on powerpc64: +#ifdef UNR64_LOCKED +uint64_t alloc_unr64(struct unrhdr64 *); +#else . . . and: +#ifdef UNR64_LOCKED +uint64_t +alloc_unr64(struct unrhdr64 *unr64) +{ + uint64_t item; + + mtx_lock(&unitmtx); + item =3D unr64->counter++; + mtx_unlock(&unitmtx); + return (item); +} +#endif Was that the intent for powerpc64? Notes about the powerpc64 context used: # uname -apKU FreeBSD FBSDG5L 12.0-ALPHA8 FreeBSD 12.0-ALPHA8 #4 r339076M: Mon Oct 15 = 13:19:35 PDT 2018 = markmi@FBSDG5L:/usr/obj/powerpc64vtsc_xtoolchain-gcc/powerpc.powerpc64/usr= /src/powerpc.powerpc64/sys/GENERIC64vtsc-NODBG powerpc powerpc64 = 1200084 1200084 buildworld buildkernel was via devel/powerpc64-xtoolchain-gcc . =3D=3D=3D Mark Millard marklmi at yahoo.com ( dsl-only.net went away in early 2018-Mar)