From owner-svn-src-head@FreeBSD.ORG Wed May 23 02:43:05 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id DF48F1065672; Wed, 23 May 2012 02:43:05 +0000 (UTC) (envelope-from bjk@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id A89208FC0C; Wed, 23 May 2012 02:43:05 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q4N2h5Zu030704; Wed, 23 May 2012 02:43:05 GMT (envelope-from bjk@freebsd.org) Received: from localhost (bjk@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) with ESMTP id q4N2h5jB030701; Wed, 23 May 2012 02:43:05 GMT (envelope-from bjk@freebsd.org) X-Authentication-Warning: freefall.freebsd.org: bjk owned process doing -bs Date: Wed, 23 May 2012 02:43:05 +0000 (UTC) From: Benjamin Kaduk To: John Baldwin In-Reply-To: <201205211127.34052.jhb@freebsd.org> Message-ID: References: <201205181001.q4IA1VED044374@svn.freebsd.org> <201205180941.48076.jhb@freebsd.org> <20120518152436.GA9116@reks> <201205211127.34052.jhb@freebsd.org> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: svn-src-head@freebsd.org, Gleb Kurtsou , src-committers@freebsd.org, svn-src-all@freebsd.org Subject: Re: svn commit: r235601 - head/include/protocols X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 May 2012 02:43:06 -0000 On Mon, 21 May 2012, John Baldwin wrote: > On Friday, May 18, 2012 11:24:36 am Gleb Kurtsou wrote: >> On (18/05/2012 09:41), John Baldwin wrote: >>> On Friday, May 18, 2012 6:01:31 am Gleb Kurtsou wrote: >>>> Author: gleb >>>> Date: Fri May 18 10:01:31 2012 >>>> New Revision: 235601 >>>> URL: http://svn.freebsd.org/changeset/base/235601 >>>> >>>> Log: >>>> Don't use ino_t in dumprestore protocol definition. >>>> >>>> Since ino_t size is about to change to 64-bits, replace ino_t used in >>>> dump protocol definition with 32-bit dump_ino_t to preserve backward >>>> compatibility. At some point, it may be necessary to use spare fields >>>> in struct in order to fully support 64-bit inode numbers. >>>> >>>> Sponsored by: Google Summer of Code 2011 >>> >>> A question about your stat changes: did you expand dev_t to 32 bits for > the >>> AFS folks, or did you leave it as 16 bits? >> >> dev_t is already 32-bit. Changing it to 64-bit was discussed at some >> point and from what I recall no decision was made: >> >> http://marc.info/?t=129119478700005&r=1&w=2 >> >> I'm going to commit preparatory changes only for now. Then publish diff >> for testing. We can still change dev_t to 64-bit if needed. Although I >> didn't work on it. > > Ah, it was 64-bit they asked for. If it is easy to do so, I'd favor changing > it since you've already done all the hard work of rolling a new stat > structure. I'd rather err on wasting 32-bits for dev_t than having to do all > this over again. Hi John, Thanks for remembering this -- I'm still pretty swamped with other stuff and missed it. It would indeed be nice for us to have a 64-bit dev_t to work with. -Ben