From owner-svn-src-head@freebsd.org Thu Jul 13 00:11:03 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 58D20DA8C70; Thu, 13 Jul 2017 00:11:03 +0000 (UTC) (envelope-from rlibby@gmail.com) Received: from mail-wr0-x233.google.com (mail-wr0-x233.google.com [IPv6:2a00:1450:400c:c0c::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E254E7DBC5; Thu, 13 Jul 2017 00:11:02 +0000 (UTC) (envelope-from rlibby@gmail.com) Received: by mail-wr0-x233.google.com with SMTP id c11so45234925wrc.3; Wed, 12 Jul 2017 17:11:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Vt5lvUGPqJhQn6UdSibP/Mu7tXjOdrnTkcJf05Ac51A=; b=hoS8M2e3RPhx/sw0Sa/gaXt5yBcdzYpElbBQz43jelX4iVMPtIja38fHWjifk056pR c59yiggKdHUStA0wLjYKRUw3+rtDSs6WB3+gWGiEXiV+zJixFXY264N7SZY9/P1NYgL5 YfsUyISoqfwEuUCTnywdIo9vysTG1VZ0vkFM3TMBt380g5m96yXe9WiXhqiaM9Dx2l34 K80jOuMlYWcl84cnkHsGKqid6dzmvYA6srq18PwebP1IfWGzL4JJVZxYwhl61Njbp0wC zBHLeJT3oMAzQLlfkz1DLvBtO4KP38iokVqQWtOQdfRLEEGYatrcJqDWmCSwqyFFrCav pLDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Vt5lvUGPqJhQn6UdSibP/Mu7tXjOdrnTkcJf05Ac51A=; b=ZeFRgWVzQEXcxkSq5+FsAFh77X0d5yKisbPkr3dcpfbAiytMzBZ974MWiCZ1JC3j+f qskG3SEuF4OLhMksb0XTlVWu2AgqlgCYGJIh097Rbxpjw/5XsDHRa+toWvD8ORhyidmI Zuv721vda75k1zOFj+Z7JxEnAwH1xlWEjHUJYRja6xzsjAHQ3kiKBt7stQ7iLOuYN/WT FaQ4GgIqHHznP4NLOTttBWd+H53dBM6hRdTg9JQcdSYd4uLxcSCw8RqqjzLiZyWtmcCj 13+3r8Jsf9f39dhXzdk3IhrQSP7oP5I24D0QiewYhzvbEHbC9YxjVJxdFWBw6UhhTMkR M6Rg== X-Gm-Message-State: AIVw113XxR+WVZaXyCHGyleU2pvIW3BAByyKemzEXNEIdFSzcELT9edn X9I08gwm/38L/VRpuOmPuez9QGHB+Q1wtzw= X-Received: by 10.223.129.163 with SMTP id 32mr574995wra.185.1499904660743; Wed, 12 Jul 2017 17:11:00 -0700 (PDT) MIME-Version: 1.0 Received: by 10.223.161.81 with HTTP; Wed, 12 Jul 2017 17:11:00 -0700 (PDT) In-Reply-To: <25032740.sJOsNDzvpa@ralph.baldwin.cx> References: <201707120730.v6C7UExf041447@repo.freebsd.org> <20170712074326.GA41347@vlakno.cz> <25032740.sJOsNDzvpa@ralph.baldwin.cx> From: Ryan Libby Date: Wed, 12 Jul 2017 17:11:00 -0700 Message-ID: Subject: Re: svn commit: r320908 - head/sys/kern To: John Baldwin Cc: Roman Divacky , Ryan Libby , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Jul 2017 00:11:03 -0000 On Wed, Jul 12, 2017 at 3:20 PM, John Baldwin wrote: > On Wednesday, July 12, 2017 01:09:39 AM Ryan Libby wrote: >> On Wed, Jul 12, 2017 at 12:43 AM, Roman Divacky wrote: >> > Clang knows about %b modifier and can do some semantic analysis on it. >> > Currently it type checks the first arg to be an int and the second to be >> > a char*. >> > >> > Do you think it would be worth modifying the checks to include >> > this new functionality? Do you think you would like to take a stab >> > at it? >> >> Yes, I plan to send that to clang upstream. I originally had those >> changes in this commit but I was directed rather to send them first to >> upstream. See here [1] for roughly what I plan to send upstream >> (although I have since noticed some unit tests that I guess should be >> extended). >> >> For now, the semantic analysis should be fine as the change should be >> backward compatible and I haven't yet changed any of the users of >> %b to use the new capabilities. > > There is also '%b' support in GCC via -fformat-extensions. GCC 4.2.1 > probably matters less, but the external GCC toolchain ports use a patch in > /usr/ports/devel/powerpc64-gcc/files/freebsd-format-extensions that you may > need to adjust as well. Thanks. I knew about the in-tree gcc format extensions, but hadn't considered ports. I'll follow up with this in a little bit. I currently have a few other patches in gestation working through some bitrot with gcc amd64 kernel builds.