From owner-freebsd-scsi@FreeBSD.ORG Thu Jul 10 12:03:37 2014 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 2952759D for ; Thu, 10 Jul 2014 12:03:37 +0000 (UTC) Received: from lwfs1-cam.cam.lispworks.com (mail.lispworks.com [46.17.166.21]) by mx1.freebsd.org (Postfix) with ESMTP id B84DA233D for ; Thu, 10 Jul 2014 12:03:36 +0000 (UTC) Received: from higson.cam.lispworks.com (higson.cam.lispworks.com [192.168.1.7]) by lwfs1-cam.cam.lispworks.com (8.14.5/8.14.5) with ESMTP id s6AC3Rw7054356; Thu, 10 Jul 2014 13:03:27 +0100 (BST) (envelope-from martin@lispworks.com) Received: from higson.cam.lispworks.com (localhost.localdomain [127.0.0.1]) by higson.cam.lispworks.com (8.14.4) id s6AC3QZY025968; Thu, 10 Jul 2014 13:03:26 +0100 Received: (from martin@localhost) by higson.cam.lispworks.com (8.14.4/8.14.4/Submit) id s6AC3QYo025964; Thu, 10 Jul 2014 13:03:26 +0100 Date: Thu, 10 Jul 2014 13:03:26 +0100 Message-Id: <201407101203.s6AC3QYo025964@higson.cam.lispworks.com> From: Martin Simmons To: Jim Harris In-reply-to: (message from Jim Harris on Wed, 9 Jul 2014 09:44:54 -0700) Subject: Re: [Bug 191717] [iscsi] smartctl -H gives "ATA output registers missing" for a disk using the isci driver References: <53BB619B.4060908@interlog.com> <201407081145.s68Bjxn6006452@higson.cam.lispworks.com> <53BC2DC5.60005@interlog.com> Cc: freebsd-scsi@freebsd.org, samm@os2.kiev.ua, Christian.Franke@t-online.de X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jul 2014 12:03:37 -0000 >>>>> On Wed, 9 Jul 2014 09:44:54 -0700, Jim Harris said: > > I have looked a little at the smartctl code, and it does not look like it > supports fixed format sense data - at least for ATA PASSTHROUGH. It > expects additional sense length to be non-zero. smartctl could be fixed, > but I think for compatibility, I should have isci return descriptor sense > for ATA PASSTHROUGH commands instead. > > Martin - could you please test the attached patch? This passes your test > case using smartctl 6.3 r3939. Thanks, that fixes my setup too with smartctl 6.2 r3874 from ports. __Martin