From owner-svn-src-all@FreeBSD.ORG Mon Jun 15 13:50:00 2015 Return-Path: Delivered-To: svn-src-all@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 69DE3593; Mon, 15 Jun 2015 13:50:00 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id ECED49F8; Mon, 15 Jun 2015 13:49:58 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id QAA16999; Mon, 15 Jun 2015 16:49:57 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1Z4Ulw-0008s4-CN; Mon, 15 Jun 2015 16:49:56 +0300 Message-ID: <557ED7CC.7030002@FreeBSD.org> Date: Mon, 15 Jun 2015 16:49:00 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Ed Maste CC: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , svn-src-vendor@FreeBSD.org Subject: Re: svn commit: r284412 - in vendor-sys/illumos/dist/uts/common/fs/zfs: . sys References: <201506151250.t5FCoifP019075@svn.freebsd.org> <557ECD22.8090402@FreeBSD.org> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jun 2015 13:50:00 -0000 On 15/06/2015 16:42, Ed Maste wrote: > On 15 June 2015 at 09:03, Andriy Gapon wrote: >> >> I guess I could extend my script to expand 5911 to >> https://www.illumos.org/issues/5911 > > Yeah, I think that would be useful -- although it's probably too long > to go in the first line, then. > > I guess the problem is that the upstream Illumos commits follow a > certain convention, and that meaning/context is lost when they come > into FreeBSD. Linking to the original issue should take care of that. > Yes, indeed. Regular ZFS/FreeBSD hackers are aware of the conventions and places to look, but most of committers do not necessarily know of them. So, this is the format that I will try use (using this commit as an example): ======================================== 5911 ZFS "hangs" while deleting file Reviewed by: Bayard Bell Reviewed by: Alek Pinchuk Reviewed by: Simon Klinkert Reviewed by: Dan McDonald Approved by: Richard Lowe Author: Matthew Ahrens illumos/illumos-gate@46e1baa6cf6d5432f5fd231bb588df8f9570c858 https://www.illumos.org/issues/5911 ======================================== -- Andriy Gapon