From owner-svn-src-head@freebsd.org Wed Jun 12 22:51:16 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7951D15C40A9 for ; Wed, 12 Jun 2019 22:51:16 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x82b.google.com (mail-qt1-x82b.google.com [IPv6:2607:f8b0:4864:20::82b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 11630906DB for ; Wed, 12 Jun 2019 22:51:16 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x82b.google.com with SMTP id s15so20362229qtk.9 for ; Wed, 12 Jun 2019 15:51:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ns7coK6JkAwcU5C7oi+MY95bnPZICmtLkTU9ajcbyoo=; b=RxYzrPztegrv2mRWzIV02LENptVHdOcfGYxDbm26r/GlbcoQjllqAEOomujpU/IjV7 QYjn9zcAmV3yuUcLSZvpRgp11Somep1T0X2EC8kEOzywFRjnMtxuxrVtfy+7Bw6Oy3K4 53q8oFVLEukkfqmJoW1iJcwB15dsMUu5VK+VBXRbt22dQGmzxJyIqEQROQMMQ5zNFbBS hm3HVFTezE+8wQaNqs8hMbEVUctf62BdctNZNDWOswvZqeV9rcIXb3FJThyVagenncs1 75YypzKUtBqrvBfg7Eb3Ptl9E4ScghvjfpzX+3LEUiKi9fhhqRbOHTRPx22qOnnjIJOb 7osw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ns7coK6JkAwcU5C7oi+MY95bnPZICmtLkTU9ajcbyoo=; b=j7Dsd/OuIzVug9+Aj6X285R5bm/SUBYQhBtUbpWE+0dr4Typ3gRHFJoMIRaIypToHG iIY489cthsE5cTR7/gHeznKeePnY3rjbdIJiNjMCHxtquD5AdBAHuPpKRExiMVd3fk2p oo9jih2yVNWWxeVoaWxRsEkJlT+w+B4mcow8VS5eXzMjtSq/BYHPIm3Y9/XNJVhEglM9 6oG9dl8n060rTf2S1PRggTkvwNn5MReS3vQLqlOeGeCBEMM1dX/sg197PM96RFfxMl4Y csWwf+heBDpLRODcgnPIv4PpajzA+F3g7VONQX/4/x/blSyvrTQ2n3ki6kI34OTU91OR T3zg== X-Gm-Message-State: APjAAAVBtbhIup43lx6Zm9PUYySpuwGAO8272CPKhhnoxh6400/a4sce ThRO7lV270eMcDYxFbbaPziK8+r03CVSfxm9WfAT7w== X-Google-Smtp-Source: APXvYqyInDhnGD7plV2w2zZKzq9aY3As+r+ZzN7trQI4xsUwReyRSQHcnh1EGDYYEfqKAS+8a5xejh7YTQOajidCiW8= X-Received: by 2002:a0c:9230:: with SMTP id a45mr795455qva.188.1560379874921; Wed, 12 Jun 2019 15:51:14 -0700 (PDT) MIME-Version: 1.0 References: <201906100528.x5A5S4gm072561@repo.freebsd.org> <20190610110909.3e6fbc13@kalimero.tijl.coosemans.org> <20190612224255.GA67242@FreeBSD.org> In-Reply-To: <20190612224255.GA67242@FreeBSD.org> From: Warner Losh Date: Wed, 12 Jun 2019 16:51:03 -0600 Message-ID: Subject: Re: svn commit: r348847 - head/sys/sys To: Gleb Smirnoff Cc: =?UTF-8?Q?T=C4=B3l_Coosemans?= , Dmitry Chagin , src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 11630906DB X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.96 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.96)[-0.964,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Jun 2019 22:51:16 -0000 On Wed, Jun 12, 2019 at 4:49 PM Gleb Smirnoff wrote: > On Mon, Jun 10, 2019 at 11:09:09AM +0200, T=C4=B3l Coosemans wrote: > T> > Date: Mon Jun 10 05:28:03 2019 > T> > New Revision: 348847 > T> > URL: https://svnweb.freebsd.org/changeset/base/348847 > T> > > T> > Log: > T> > Use C11 anonymous unions. > T> > > T> > PR: 215202 > T> > Reported by: glebius > T> > MFC after: 2 weeks > T> > > T> > Modified: > T> > head/sys/sys/ucred.h > T> > > T> > Modified: head/sys/sys/ucred.h > T> > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > T> > --- head/sys/sys/ucred.h Mon Jun 10 05:09:34 2019 (r348846) > T> > +++ head/sys/sys/ucred.h Mon Jun 10 05:28:03 2019 (r348847) > T> > @@ -89,12 +89,11 @@ struct xucred { > T> > gid_t cr_groups[XU_NGROUPS]; /* groups */ > T> > union { > T> > void *_cr_unused1; /* compatibility with old ucred *= / > T> > - pid_t _pid; > T> > - } _cr; > T> > + pid_t cr_pid; > T> > + }; > T> > }; > T> > #define XUCRED_VERSION 0 > T> > > T> > -#define cr_pid _cr._pid > T> > /* This can be used for both ucred and xucred structures. */ > T> > #define cr_gid cr_groups[0] > T> > T> Isn't this a userland header that should work with non-C11 compilers? > > It could make sense to keep such low bar for standard headers, but ucred.= h > is BSD-specific header and struct xucred is FreeBSD specific. > This is solvable with proper visibility, I'd think.. Warner