From owner-svn-ports-all@freebsd.org Mon Dec 18 09:15:42 2017 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 906C3E81547; Mon, 18 Dec 2017 09:15:42 +0000 (UTC) (envelope-from rodrigo@FreeBSD.org) Received: from smtp.osorio.me (smtp.osorio.me [5.196.94.126]) by mx1.freebsd.org (Postfix) with ESMTP id 4FB1871C07; Mon, 18 Dec 2017 09:15:41 +0000 (UTC) (envelope-from rodrigo@FreeBSD.org) Received: from [172.16.33.187] (unknown [213.174.108.235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.osorio.me (Postfix) with ESMTPSA id 3A256323E2; Mon, 18 Dec 2017 09:15:40 +0000 (UTC) Subject: Re: svn commit: r456527 - in head/databases: . postgis20 postgis21 postgis22 postgis23 postgis24 To: Alexey Dokuchaev Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201712171125.vBHBPEGU053728@repo.freebsd.org> <20171217114147.GA19802@FreeBSD.org> <20171218010012.GA76552@FreeBSD.org> From: Rodrigo Osorio Message-ID: <49742f49-87aa-9f6e-21ff-20ad5d1598cd@FreeBSD.org> Date: Mon, 18 Dec 2017 10:15:39 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171218010012.GA76552@FreeBSD.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Dec 2017 09:15:42 -0000 On 12/18/17 02:00, Alexey Dokuchaev wrote: > On Sun, Dec 17, 2017 at 01:25:43PM +0100, Rodrigo Osorio wrote: >> On 12/17/17 12:41, Alexey Dokuchaev wrote: >>> On Sun, Dec 17, 2017 at 11:25:14AM +0000, Rodrigo Osorio wrote: >>>> New Revision: 456527 >>>> URL: https://svnweb.freebsd.org/changeset/ports/456527 >>>> >>>> Log: >>>> Add new port postgis24 for v2.4.x >>>> >>>> Added: >>>> head/databases/postgis24/ >>>> head/databases/postgis24/Makefile (contents, props changed) >>>> head/databases/postgis24/distinfo (contents, props changed) >>>> head/databases/postgis24/pkg-descr (contents, props changed) >>>> head/databases/postgis24/pkg-install (contents, props changed) >>>> head/databases/postgis24/pkg-plist (contents, props changed) >>> Looks like it should've been repocopied, not added as a new port. >>> Can you explain why this wasn't done? >> I don't get your question, do you see any issue regarding postgis24 port? > I have an issue not with the port per se, but with the way it was carried > out (added to the collection). Please read Section 19.4* of the Ports > Committer's Guide, albeit I'm surprised that your mentor did not tell you > about it earlier. Now I understand... To clarify my mentor instruct me about the procedure but it was a long time ago. I don't do this kind of commit so often, and this is probably my mistake. > If you're subscribed to svn-ports-* ML (like you should), you would have > also known about this procedure, it's not something uncommon. > > ./danfe > > *) https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/ports.html#ports-qa-repocopies >