From owner-freebsd-bugs@FreeBSD.ORG Fri Nov 4 12:40:13 2005 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A9EC416A41F for ; Fri, 4 Nov 2005 12:40:13 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 12C9043D48 for ; Fri, 4 Nov 2005 12:40:13 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id jA4CeC4w036358 for ; Fri, 4 Nov 2005 12:40:12 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id jA4CeCMM036357; Fri, 4 Nov 2005 12:40:12 GMT (envelope-from gnats) Resent-Date: Fri, 4 Nov 2005 12:40:12 GMT Resent-Message-Id: <200511041240.jA4CeCMM036357@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Dominik Brettnacher Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E3F1816A420 for ; Fri, 4 Nov 2005 12:30:20 +0000 (GMT) (envelope-from domi@debussy.saargate.de) Received: from jail.teresto.net (jail.teresto.net [212.88.134.36]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7708B43D45 for ; Fri, 4 Nov 2005 12:30:20 +0000 (GMT) (envelope-from domi@debussy.saargate.de) Received: from dominik.saargate.de ([212.88.133.188] helo=debussy.saargate.de) by jail.teresto.net with esmtp (Exim 4.42 (FreeBSD)) id 1EXzD4-000Hvn-Ht for FreeBSD-gnats-submit@freebsd.org; Fri, 04 Nov 2005 11:54:15 +0100 Received: from debussy.saargate.de (localhost [127.0.0.1]) by debussy.saargate.de (8.13.3/8.13.3) with ESMTP id jA4As2K9000877 for ; Fri, 4 Nov 2005 11:54:02 +0100 (CET) (envelope-from domi@debussy.saargate.de) Received: (from domi@localhost) by debussy.saargate.de (8.13.3/8.13.3/Submit) id jA4As2xu000876; Fri, 4 Nov 2005 11:54:02 +0100 (CET) (envelope-from domi) Message-Id: <200511041054.jA4As2xu000876@debussy.saargate.de> Date: Fri, 4 Nov 2005 11:54:02 +0100 (CET) From: Dominik Brettnacher To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: bin/88486: [patch] make periodic(8) quiet (configurable) when no output was generated X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Dominik Brettnacher List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Nov 2005 12:40:13 -0000 >Number: 88486 >Category: bin >Synopsis: [patch] make periodic(8) quiet (configurable) when no output was generated >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Fri Nov 04 12:40:12 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Dominik Brettnacher >Release: FreeBSD 5.4-RELEASE i386 >Organization: >Environment: System: FreeBSD debussy.saargate.de 5.4-RELEASE FreeBSD 5.4-RELEASE #4: Tue Aug 23 12:00:38 CEST 2005 domi@debussy.saargate.de:/usr/obj/usr/src/sys/DEBUSSY i386 >Description: By default, periodic(8) outputs a notification like "No output from the x files processed" if the scripts executed did not generate any output. While this is useful to know whether the scripts have been executed at all, notifications like these are too verbose in certain environments. The attached patch introduces a new option "_show_empty_output" to make this configurable. Setting it to YES (the default) results in the known behaviour. Setting it to NO means that no output (and thus no mail, if periodic output is sent out via mail) is generated. >How-To-Repeat: >Fix: --- /usr/sbin/periodic Thu Apr 3 10:55:30 2003 +++ periodic Mon Oct 31 17:13:39 2005 @@ -40,11 +40,11 @@ case "$output" in /*) pipe="cat >>$output";; "") pipe=cat;; - *) pipe="mail -s '$host ${arg##*/} run output' $output";; + *) pipe="mail -E -s '$host ${arg##*/} run output' $output";; esac - success=YES info=YES badconfig=NO # Defaults when ${run}_* aren't YES/NO - for var in success info badconfig + success=YES info=YES badconfig=NO empty_output=YES # Defaults when ${run}_* aren't YES/NO + for var in success info badconfig empty_output do case $(eval echo "\$${arg##*/}_show_$var") in [Yy][Ee][Ss]) eval $var=YES;; @@ -95,8 +95,11 @@ done if [ $empty = TRUE ] then - [ $processed = 1 ] && plural= || plural=s - echo "No output from the $processed file$plural processed" + if [ $empty_output = TRUE ] + then + [ $processed = 1 ] && plural= || plural=s + echo "No output from the $processed file$plural processed" + fi else echo "" echo "-- End of $arg output --" >Release-Note: >Audit-Trail: >Unformatted: