From owner-cvs-src@FreeBSD.ORG Thu Mar 10 08:38:26 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AC7C216A4CE; Thu, 10 Mar 2005 08:38:26 +0000 (GMT) Received: from pd4mo3so.prod.shaw.ca (shawidc-mo1.cg.shawcable.net [24.71.223.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5790C43D5D; Thu, 10 Mar 2005 08:38:26 +0000 (GMT) (envelope-from cperciva@freebsd.org) Received: from pd3mr7so.prod.shaw.ca (pd3mr7so-qfe3.prod.shaw.ca [10.0.141.23])2004)) with ESMTP id <0ID400ERGNZLM150@l-daemon>; Thu, 10 Mar 2005 01:38:09 -0700 (MST) Received: from pn2ml4so.prod.shaw.ca ([10.0.121.148]) by pd3mr7so.prod.shaw.ca (Sun ONE Messaging Server 6.0 HotFix 1.01 (built Mar 15 2004)) with ESMTP id <0ID400HPZNZLTH40@pd3mr7so.prod.shaw.ca>; Thu, 10 Mar 2005 01:38:09 -0700 (MST) Received: from [192.168.0.60] (S0106006067227a4a.vc.shawcable.net [24.87.209.6]) by l-daemon (iPlanet Messaging Server 5.2 HotFix 1.18 (built Jul 28 2003)) with ESMTP id <0ID400FIUNZKJU@l-daemon>; Thu, 10 Mar 2005 01:38:08 -0700 (MST) Date: Thu, 10 Mar 2005 00:38:08 -0800 From: Colin Percival In-reply-to: <200503100829.j2A8TJm9081256@grovel.grondar.org> To: Mark Murray Message-id: <42300770.7040409@freebsd.org> MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: 7bit X-Accept-Language: en-us, en X-Enigmail-Version: 0.90.1.0 X-Enigmail-Supports: pgp-inline, pgp-mime References: <200503100829.j2A8TJm9081256@grovel.grondar.org> User-Agent: Mozilla Thunderbird 1.0 (X11/20050302) cc: Peter Jeremy cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG cc: cvs-src@FreeBSD.ORG Subject: Re: cvs commit: src/lib/libmd Makefile sha256.3 sha256.h sha256c.c shadriver.c src/sbin/md5 Makefile md5.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Mar 2005 08:38:26 -0000 Mark Murray wrote: > Colin Percival writes: >>hash functions don't get upgraded to newer versions or have new >>features added. (Ok, they do, but they get a new name and the old >>versions are left unchanged.) > > But they do have bugs fixed or are optimised. Optimized? Perhaps. Bugs fixed? Almost certainly not -- writing a hash implementation which works for all the test vectors while failing for some other data would be very difficult. There's only one code path through the compression function, and only a very small number through the wrappers -- if you get something wrong, it's going to bite you every time. Colin Percival